Page MenuHomeSolus

Update inkscape to 1.0
ClosedPublic

Authored by serebit on May 5 2020, 5:47 PM.
Tags
None
Referenced Files
F11022468: D8811.diff
Tue, Aug 8, 1:13 AM
F10930622: D8811.id21124.diff
Tue, Jul 11, 2:38 PM
F10866326: D8811.id21132.diff
Jun 17 2023, 3:02 PM
F10865794: D8811.id21124.diff
Jun 17 2023, 1:00 PM
F10865399: D8811.id21192.diff
Jun 17 2023, 11:19 AM
F10863851: D8811.id21162.diff
Jun 17 2023, 4:35 AM
F10863602: D8811.id21202.diff
Jun 17 2023, 3:15 AM
F10856179: D8811.diff
Jun 14 2023, 8:28 PM
Subscribers
Tokens
"Love" token, awarded by Jacalz.

Details

Summary

Too many changes to be able to adequately summarize. Most noticeable change is a shift to GTK3. Full release notes are here.

Test Plan

Drew a smiley face :)

Diff Detail

Repository
R1470 inkscape
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I've already found a reproducible crash, by the way, so it might be worth holding off until a bugfix release for 1.0.

Thanks for posting the revision. I wish that I could make the source download on my end to build it correctly, but it just wont budge.
I posted a comment with some suggestions that I think could improve things a bit :)

package.yml
36

I guess that you saw that libdbus-glib-1.so.2 was removed from pspec, but this is just because dbus is disabled by default. Should preferably be enabled again using -DWITH_DBUS=ON to still have dbus implementation like before.

You could probably also switch to building using ninja to speed up the build a bunch. You just do %cmake_ninja, %ninja_build and %ninja_install instead of regular cmake and make commands. I think that it might drop the need for creating a build folder too, I am not fully certain, but I believe so which means that it might be worth a try ;)

According to the release notes, dbus is no longer used for HTTP requests (libsoup is used instead), so I assumed it isn't needed anymore. If this isn't the case, I can add it back.

Use ninja, not because it's fewer lines, but because it's called ninja

@serebit I think I missed that when reading the release notes. I don't think you need to add it back, you can probably just keep it as it is then. Looks good to me :)

JoshStrobl added a subscriber: JoshStrobl.

You have a bunch of redundant pkgconfigs that need to be removed or cleaned up, whether they're references to the same package, builddeps, or revdeps of something you already have listed.

I've already found a reproducible crash

Has this been reported to Inkscape? I'm hesistant to land Inkscape no matter how new and fancy it is if you're able to experience crashes so easily.

This revision now requires changes to proceed.May 6 2020, 6:24 PM

Remove redundant build deps (hopefully got all of them)

Has this been reported to Inkscape? I'm hesistant to land Inkscape no matter how new and fancy it is if you're able to experience crashes so easily.

I was about to report the issue, but I can no longer reproduce it. Build deps are resolved now.

Otherwise LGTM

package.yml
12–13

Not needed, is a dep of libgtkmm-3

23–24

Not required. Dep of gdk-pixbuf-devel, which is a dep of libgtk-3-devel, which is a dep of libgtkmm-3-devel

This revision now requires changes to proceed.May 8 2020, 5:56 AM

Removed more redundant build deps as per Josh's request

This revision is now accepted and ready to land.May 9 2020, 4:52 AM
This revision was automatically updated to reflect the committed changes.