Paths

Table of Contentst

Differential D8810

Initial commit of gdl, required for Inkscape 1.0
ClosedPublic
Actions

Authored by • serebit on May 5 2020, 5:44 PM.

Tags

None

Referenced Files

	F11049588: D8810.id.diff
	Thu, Aug 10, 5:55 PM

	F11049587: D8810.id21201.diff
	Thu, Aug 10, 5:55 PM

	F11049586: D8810.id21123.diff
	Thu, Aug 10, 5:55 PM

	F11049583: D8810.id21161.diff
	Thu, Aug 10, 5:55 PM

	F11049582: D8810.id21131.diff
	Thu, Aug 10, 5:55 PM

	F11035205: D8810.diff
	Wed, Aug 9, 5:39 PM

	F10941549: D8810.id21201.diff
	Fri, Jul 14, 6:34 AM

	F10939469: D8810.id21131.diff
	Thu, Jul 13, 11:19 PM

View All 17 Files

Subscribers

Tokens

"Love" token, awarded by Jacalz.

Details

Reviewers

Group Reviewers

Commits

R4964:09d68ae3b31f: Initial commit of gdl, required for Inkscape 1.0

Summary

Starts with version 3.34.0.

Test Plan

Built Inkscape 1.0.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• serebit created this revision.May 5 2020, 5:44 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 5 2020, 5:44 PM

• serebit requested review of this revision.May 5 2020, 5:44 PM

• serebit added a child revision: D8811: Update inkscape to 1.0.May 5 2020, 5:48 PM

Jacalz added a subscriber: Jacalz.May 5 2020, 6:50 PM

Jacalz added inline comments.

package.yml
19	You could probably move this to `%autogen` and remove `./autogen.sh` and `%configure` :)

Jacalz awarded a token.May 5 2020, 6:50 PM

livingsilver94 added a subscriber: livingsilver94.May 5 2020, 7:11 PM

livingsilver94 added inline comments.

package.yml
5	According to the packages that Josh maintains, the preferred path would be https://download.gnome.org/sources/gdl

Use different source, eliminates need for automake

• serebit marked 2 inline comments as done.May 5 2020, 8:10 PM

JoshStrobl requested changes to this revision.May 6 2020, 6:28 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
8	More appropriate for it to be in programming.library IMO. desktop.gtk should really be reduced to strictly what is required for GTK3 itself (yea, some things should be moved).
13	Part of system.devel, not needed.
15	Can disable the docs, nobody is realistically gonna read developer documentation for this library locally.
17	Part of system.devel, not needed.

This revision now requires changes to proceed.May 6 2020, 6:28 PM

switch back to old source to patch makefile.am and configure.in, disabling docs

LGTM, thanks for the cleanup and doc removal. Frustrating they wouldn't provide a compile-time option to disable docs.

This revision is now accepted and ready to land.May 8 2020, 5:52 AM

Closed by commit R4964:09d68ae3b31f: Initial commit of gdl, required for Inkscape 1.0 (authored by • serebit, committed by JoshStrobl). · Explain WhyMay 9 2020, 4:53 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4964:09d68ae3b31f: Initial commit of gdl, required for Inkscape 1.0.

Revision Contents
Changeset List

Path

Size

1 line

148 lines

8 lines

23 lines

pspec_x86_64.xml

136 lines

Diff 21123

Makefile

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...