Page MenuHomeSolus

Update handbrake to 1.3.2
ClosedPublic

Authored by aleksvor on May 4 2020, 8:38 AM.
Tags
None
Referenced Files
F11065816: D8805.diff
Fri, Aug 11, 5:18 PM
F10942067: D8805.diff
Fri, Jul 14, 9:17 AM
F10865792: D8805.id21115.diff
Jun 17 2023, 12:59 PM
F10864405: D8805.id21117.diff
Jun 17 2023, 7:52 AM
F10863004: D8805.id21142.diff
Jun 17 2023, 12:09 AM
F10861839: D8805.id21119.diff
Jun 16 2023, 4:57 PM
F10856441: D8805.diff
Jun 14 2023, 9:11 PM
F10769159: D8805.id.diff
May 20 2023, 1:24 PM
Tokens
"Like" token, awarded by Jacalz.

Details

Summary

Changelog:

  • General
    • Fixed point to point end detection in certain scenarios.
    • Improved support for H.265 video in AVI container produced by some security cameras.
    • Added logging to identify problematic sources where container and video track pixel aspect ratios differ.
    • Added logging to help debug potential JSON API issues.
  • Video
    • Fixed color range conversion being applied twice when scaling video.
    • Fixed incorrect identification of support for QSV HEVC encoder on older Intel hardware.
    • Added logging to identify automatic picture rotation.
    • Miscellaneous bug fixes and improvements.
  • Audio
    • Fixed an upstream FFmpeg issue where passing through AAC ADTS audio could produce invalid MKV output in rare cases (error instead).
  • Filters
    • Fixed uninitialized memory in NLMeans prefilter leading to video corruption at bottom of picture (only affects custom settings).
    • Fixed a crash in the Detelecine filter with out of bounds parameters (only affects custom settings).
  • Subtitles
    • Fixed burned in subtitles position offset where cropscale filter is not used.
  • Command line interface
    • Fixed subtitles not being selected when specifying --all-subtitles without also specifying a non-empty --subtitle-lang-list.
  • Build system
    • Miscellaneous bug fixes and improvements.
  • Linux
    • Fixed point to point controls not accepting fractional seconds.
    • Fixed updating presets with identical names in different categories.
    • Improved parity with other platforms by allowing removal of preset categories (automatic after last preset in category is removed).
    • Improved parity with other platforms by showing title and chapter range on the queue summary tab.
Test Plan

Transcoded H264 video using one of the standard presets and tested the resulting video in MediaInfo and mpv.

Diff Detail

Repository
R1133 handbrake
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

livingsilver94 added inline comments.
package.yml
35

Why not %JOBS%?

package.yml
35

Because %JOBS% expands to -j<number of jobs> and turns this line into --launch-jobs=-j<number of jobs>, while configuration script expects just integer value. I wasn't able to find any Solus macro that expands just to number of available cores without -j prefix.

package.yml
35

You're right. The correct macro seems to be %YJOBS%, according to this: https://github.com/getsolus/ypkg/blob/master/ypkg2/rc.yml

On my system it resolves to 8 so I'd say it's working fine.

Added %YJOBS% macro to set the amount of parallel jobs.
Thanks @livingsilver94 for pointing it out :)

Adjusted build flags:

  1. Enabled hardening against buffer overflows. Probably some of these settings were already enabled by our standard $CFLAGS, but I guess it won't hurt to enable hardening flags from HB devs.
  2. Enabled Intel QSV and AMD VCE for hardware-accelerated encoding on supported Intel/AMD GPUs; NVIDIA Video Codec was already enabled by default. This introduces dependency on libva.
  3. Removed libbluray and libsamplerate from builddeps - seems that HandBrake's build system uses vendored versions of these libs anyway.
JoshStrobl added a subscriber: JoshStrobl.

LGTM and thanks for the improvements with regards to hardware acceleration ?

This revision is now accepted and ready to land.May 6 2020, 4:54 PM
This revision was automatically updated to reflect the committed changes.