Page MenuHomeSolus

Initial commit of tdrop
ClosedPublic

Authored by akrenz on May 1 2020, 10:30 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8523: tdrop
Commits
R4973:54048cd15660: Initial commit of tdrop
Summary

Fixes T8523

Test Plan

Run the following command from terminal to start a gnome-terminal dropdown tdrop -ma -w -4 -s dropdown gnome-terminal

Diff Detail

Repository
R4973 tdrop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.May 1 2020, 10:30 PM
akrenz requested review of this revision.May 1 2020, 10:30 PM
akrenz edited the summary of this revision. (Show Details)May 1 2020, 10:30 PM
akrenz added a task: T8523: tdrop.
DataDrake requested changes to this revision.May 13 2020, 7:28 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
11

typo "dropwdowns"

pspec_x86_64.xml
23

Should be /usr/ not /usr/local

This revision now requires changes to proceed.May 13 2020, 7:28 AM
akrenz updated this revision to Diff 21293.May 13 2020, 12:06 PM

fix typo "dropwdown" and install under '/usr/' instead of '/usr/local/'

akrenz marked 2 inline comments as done.May 13 2020, 12:06 PM
DataDrake accepted this revision.May 13 2020, 3:15 PM

LGTM. Thanks!

This revision is now accepted and ready to land.May 13 2020, 3:15 PM
This revision was automatically updated to reflect the committed changes.