Page MenuHomeSolus

Update tlp to version 1.3.1

Authored by akrenz on May 1 2020, 8:02 PM.



Fixes T8740
Configuration has been moved from /etf/default.tlp to /etc/tlp.conf. Enable all previously enabled
options from configuration by patch (all options are by default disabled in latest tlp versions)

Complete changes since 1.2.1 see:

Test Plan

Enabled and disabled tlp via systemctl. Check changes in battery runtime (between enabled and disabled).
Added config to set battery charging threshold in /etc/tlp.d/ and verified that it was enabled bi tlp-stat -b (after systemctl restart)

Diff Detail

R3046 tlp
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.May 1 2020, 8:02 PM
akrenz requested review of this revision.May 1 2020, 8:02 PM
akrenz edited the summary of this revision. (Show Details)May 1 2020, 8:24 PM
akrenz retitled this revision from Update to version 1.3.1 to Update tlp to version 1.3.1.
akrenz added a project: Software.
DataDrake requested changes to this revision.May 17 2020, 2:55 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.

Seem a bit redundant to patch and to sed the config. Maybe one or the other? The main reason we used sed was to avoid having to rebase a config patch. Or maybe neighter? If we are overriding that much of the default config, it might just make sense to have our own tlp.conf in files/ that gets installed over the default tlp.conf.

This revision now requires changes to proceed.May 17 2020, 2:55 AM
akrenz updated this revision to Diff 21433.May 17 2020, 10:09 AM
akrenz edited the summary of this revision. (Show Details)

Only use patch for changing/enabling options inside tlp.conf. I think shipping a tlp.conf via files is not a good option. By doing so we could miss adding upcoming features in next releases. By using a patch they are at least available in the config (even if disabled by default). So they can be activated by the users more easily.

DataDrake accepted this revision.Jun 13 2020, 5:38 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jun 13 2020, 5:38 PM
This revision was automatically updated to reflect the committed changes.