Details
- Reviewers
DataDrake - Group Reviewers
Triage Team - Maniphest Tasks
- T8740: Update tlp to 1.3.1
- Commits
- R3046:2459940f9fc6: Update tlp to version 1.3.1
Enabled and disabled tlp via systemctl. Check changes in battery runtime (between enabled and disabled).
Added config to set battery charging threshold in /etc/tlp.d/ and verified that it was enabled bi tlp-stat -b (after systemctl restart)
Diff Detail
- Repository
- R3046 tlp
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| package.yml | ||
|---|---|---|
| 21 | Seem a bit redundant to patch and to sed the config. Maybe one or the other? The main reason we used sed was to avoid having to rebase a config patch. Or maybe neighter? If we are overriding that much of the default config, it might just make sense to have our own tlp.conf in files/ that gets installed over the default tlp.conf. | |
Only use patch for changing/enabling options inside tlp.conf. I think shipping a tlp.conf via files is not a good option. By doing so we could miss adding upcoming features in next releases. By using a patch they are at least available in the config (even if disabled by default). So they can be activated by the users more easily.