Update Keybase to 5.5.2
ClosedPublic
Actions

Authored by alecbcs on Apr 30 2020, 5:10 PM.

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Triage Team

Commits

R4442:fcb4ecb6881e: Update Keybase to 5.5.2

Summary

Updated Keybase to 5.5.2 which includes multiple bug fixes and new features.

Changelog:

Fixed issues with the system tray introduced in v5.3.0 by upgrading Electron version.
Administering groups is easier than ever with the redesigned Teams tab.
Better handling of audio attachments in info panel.
Forward images and attachments in chat.
Improved file sharing with email addresses.
Fix issue with custom emoji naming conflicts.
Fix KBFS performance issues.
Search for bots and open teams from your inbox.
Fixed a bug where the GUI would immediately segfault upon start.

Test Plan

Tested 5.5.2 by sending and receiving chats as well as adding data to an encrypted git repo. Everything looked and functioned as expected.

Diff Detail

Repository

R4442 keybase

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alecbcs created this revision.Apr 30 2020, 5:10 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptApr 30 2020, 5:10 PM

alecbcs requested review of this revision.Apr 30 2020, 5:10 PM

alecbcs edited the summary of this revision. (Show Details)Apr 30 2020, 5:13 PM

Just a note from me: This breaks try icon compatibility in e.g. Budgie. Which is why I haven't updated it yet.
Then again, Riot sneaked the same change in without me noticing, so it's probably not such a huge deal. Just a bit annyoing.

In D8774#141926, @Staudey wrote:

Just a note from me: This breaks try icon compatibility in e.g. Budgie. Which is why I haven't updated it yet.
Then again, Riot sneaked the same change in without me noticing, so it's probably not such a huge deal. Just a bit annyoing.

@Staudey Good catch! I hadn't noticed the missing tray icon. After looking more into the issue here. It seems like the newest version of chromium has dropped support for libappindicator which means electron 8.x no longer supports it as well. I'll look into patching the yarn config to use electron 7.x instead of 8.x.

In this case that might be possible, though I wouldn't count on it. Unfortunately in the case of Riot they were actively using Electron 8 features.

alecbcs planned changes to this revision.May 1 2020, 3:31 PM

DataDrake mentioned this in T8960: Singal-desktop tray icon stopped working.May 17 2020, 4:50 AM

You should be able to update this to 5.5.2 to resolve system tray issues: https://github.com/keybase/client/releases/tag/v5.5.2

@JoshStrobl: Just fyi, I tried the new version on my PC and it seemed like the tray icon still didn't work. BUT this was also a time of Budgie updates and a bit hectic on my end, so it might just be that I didn't test correctly.

Sorry for the delay everyone! I'd missed the notification for this. I'll give it a build & test tomorrow to see if we can't get the tray icon to work again.

Patched to 5.5.2 and I can confirm that the tray icon is back!

alecbcs retitled this revision from Update Keybase to 5.4.2 to Update Keybase to 5.5.2.Nov 1 2020, 6:07 PM

alecbcs edited the summary of this revision. (Show Details)

alecbcs edited the test plan for this revision. (Show Details)