Page MenuHomeSolus

Initial commit of OTPClient
ClosedPublic

Authored by akrenz on Apr 22 2020, 6:43 AM.

Details

Summary

Initial comit for OTPClient

Fixes T8908
Depends on D8722 D8721 D8720

Test Plan

Create a new database and a an entry via QRCode from https://github.com/mdp/rotp. This will
(try it via Screenshot, Clipboard and file) add an entry for alice@google.com. Next try to generate an OTP code.

Diff Detail

Repository
R4982 OTPClient
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Apr 22 2020, 6:43 AM
akrenz requested review of this revision.Apr 22 2020, 6:43 AM
algent added a subscriber: algent.Apr 23 2020, 2:04 PM

Edit your Summary and below Fixes T8908 add a new line with Depends on D8721 D8722

Girtablulu retitled this revision from Initial commit to Initial commit of OTPClient.Apr 23 2020, 3:27 PM
Girtablulu requested changes to this revision.Apr 23 2020, 3:30 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
7

should be SPDX conform

https://spdx.org/licenses/preview/

13

this is set by default, so not needed

27

remove the - after |

This revision now requires changes to proceed.Apr 23 2020, 3:30 PM
akrenz updated this revision to Diff 20967.Apr 25 2020, 7:42 PM

Change license identifier to GPL-3.0-or-later (SPDX) and remove "-" from install step. "netowrking: no" removed and enable stripping

akrenz marked 3 inline comments as done.Apr 25 2020, 7:42 PM

anything further needed?

DataDrake accepted this revision.May 13 2020, 8:45 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.May 13 2020, 4:10 PM
Closed by commit R4982:3c33a4953b54: Initial commit of OTPClient (authored by akrenz, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.