Page MenuHomeSolus

Initial commit of libcotp
ClosedPublic

Authored by akrenz on Apr 22 2020, 6:29 AM.

Details

Summary

This is a dependency needed for T8908

Depends on D8720

Test Plan

Test it with OTPClient. See OTPClient Test Plan.

Diff Detail

Repository
R4974 libcotp
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Apr 22 2020, 6:29 AM
akrenz requested review of this revision.Apr 22 2020, 6:29 AM
akrenz edited the summary of this revision. (Show Details)Apr 23 2020, 3:07 PM
Girtablulu requested changes to this revision.Apr 23 2020, 3:31 PM
Girtablulu retitled this revision from Initial commit to Initial commit of libcotp.
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
12

not needed should be done by default

20

please remove the - after |

This revision now requires changes to proceed.Apr 23 2020, 3:32 PM
akrenz updated this revision to Diff 20960.Apr 25 2020, 10:40 AM

removed "strip: yes" and "-" from install step

akrenz marked 2 inline comments as done.Apr 25 2020, 12:23 PM
DataDrake requested changes to this revision.May 13 2020, 8:40 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
8

Should be programming.library. programming.devel is reserved for -devel packages.

This revision now requires changes to proceed.May 13 2020, 8:40 AM
akrenz updated this revision to Diff 21295.May 13 2020, 12:10 PM

Change component to programming.library

akrenz marked an inline comment as done.May 13 2020, 12:11 PM
DataDrake accepted this revision.May 13 2020, 3:16 PM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.May 13 2020, 3:17 PM
Closed by commit R4974:7a983f1edd05: Initial commit of libcotp (authored by akrenz, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.