Page MenuHomeSolus

Initial commit of libbaseencode
ClosedPublic

Authored by akrenz on Apr 22 2020, 6:27 AM.

Details

Summary

This is a dependency needed for T8908

Test Plan

Test it with package OTPClient. See testplan of OTPClient

Diff Detail

Repository
R4970 libbaseencode
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Apr 22 2020, 6:27 AM
akrenz requested review of this revision.Apr 22 2020, 6:27 AM
Girtablulu requested changes to this revision.Apr 23 2020, 3:30 PM
Girtablulu retitled this revision from Initial commit to Initial commit of libbaseencode.
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
17

remove the - after |

This revision now requires changes to proceed.Apr 23 2020, 3:31 PM
akrenz updated this revision to Diff 20961.Apr 25 2020, 10:44 AM

removed "strip: yes" and "-" from install step

akrenz marked an inline comment as done.Apr 25 2020, 12:23 PM
DataDrake accepted this revision.May 13 2020, 7:24 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.May 13 2020, 7:24 AM
Closed by commit R4970:f3aee599f621: Initial commit of libbaseencode (authored by akrenz, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.