Page MenuHomeSolus

Use JAVA_HOME for kotlin-native
ClosedPublic

Authored by serebit on Apr 18 2020, 12:39 AM.

Details

Summary

Explicitly set the JAVA_HOME environment variable to make @DataDrake's job easier when he has the time to make the JDK changes.

Built and ran with a version of openjdk-8 that has the /usr/bin/java* symlinks removed.

Test Plan

Build wraith-master and run a short test program

Diff Detail

Repository
R4853 kotlin-native
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Apr 18 2020, 12:39 AM
serebit requested review of this revision.Apr 18 2020, 12:39 AM
serebit edited the summary of this revision. (Show Details)Apr 18 2020, 12:49 AM

Does this also make kotlin-native explicitly use openjdk-8 at runtime or that's a different story?

That's a different story, but I can make those changes as well.

serebit planned changes to this revision.May 1 2020, 5:06 PM

If you had the time, that'd be awesome, you certainly have a better understanding of Kotlin than me. Otherwise, yeah, I can patch it like any other Java-dependent package before.

serebit added a comment.EditedMay 2 2020, 4:47 AM

If you had the time, that'd be awesome, you certainly have a better understanding of Kotlin than me. Otherwise, yeah, I can patch it like any other Java-dependent package before.

I may have more experience with Kotlin, but you have more experience with patching packages to use JAVA_HOME :p I'll let you handle it, just drop a comment in here once you get the differential done and I'll abandon this one.

Edit: Actually, never mind, I might as well finish what I started!

serebit updated this revision to Diff 21099.May 2 2020, 3:50 PM

Explicitly set JAVA_HOME for kotlin-native binaries

serebit retitled this revision from Use JAVA_HOME for kotlin-native build to Use JAVA_HOME for kotlin-native.May 2 2020, 3:51 PM
serebit edited the summary of this revision. (Show Details)
serebit edited the test plan for this revision. (Show Details)
DataDrake accepted this revision.May 13 2020, 6:03 AM

LGTM. Thanks!

This revision is now accepted and ready to land.May 13 2020, 6:03 AM
This revision was automatically updated to reflect the committed changes.