Page MenuHomeSolus

Improve lightdm-wrapper (to resolve T8859)
AbandonedPublic

Authored by Schteve on Apr 14 2020, 6:49 PM.
Tags
None
Referenced Files
F11051820: D8678.id.diff
Thu, Aug 10, 8:20 PM
F11051819: D8678.id20827.diff
Thu, Aug 10, 8:20 PM
F11036246: D8678.diff
Wed, Aug 9, 7:08 PM
F10998264: D8678.diff
Thu, Jul 27, 8:21 PM
F10983708: D8678.diff
Sun, Jul 23, 3:17 PM
F10893574: D8678.id20827.diff
Jun 30 2023, 10:51 PM
F10882346: D8678.id20827.diff
Jun 23 2023, 10:19 AM
F10874822: D8678.diff
Jun 20 2023, 2:27 AM
Subscribers

Details

Reviewers
ermo
Group Reviewers
Triage Team
Summary

Adopt a standard lightdm-wrapper so that the display inherits user-set
environment variables (e.g. PATH, GNUPGHOME, etc.), and configuration.

Signed-off-by: Steven Moseley <stevenmos@kolabnow.com>

Test Plan
  • I reverted my earlier fix in /etc/ and installed this version
  • After a reboot, my window manager had my environment

Diff Detail

Repository
R1955 lightdm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

On the face of it, the implementation you propose seems innocuous enough, but one can never be too sure.

Have you tried running this with all editions of Solus which install and use lightdm by default to verify that there are no regressions?

I would imagine that this would be the Budgie and MATE editions (I have no -unstable versions of either install to test on). This would be something that should be recorded in the test plan for the diff, perhaps something like:

"Tested with lighdtm on i3, Budgie and MATE with no ill effects".

As an aside, this should probably be implemented for all Xsessions, including GNOME Shell and KDE, but that's perhaps a bit out of scope for your use case...

ermo requested changes to this revision.Apr 17 2020, 12:36 AM
This revision now requires changes to proceed.Apr 17 2020, 12:36 AM
JoshStrobl added a subscriber: JoshStrobl.

Closing due to lack of response.