Page MenuHomeSolus

Initial inclusion of OpenRGB, fixes T8560
AbandonedPublic

Authored by Tzigamm on Apr 13 2020, 1:03 PM.
Tags
None
Tokens
"Yellow Medal" token, awarded by Unknown Object (User)."Like" token, awarded by daniel1986_ve."Burninate" token, awarded by jwinnie."Like" token, awarded by tomocafe.

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8560: Open Source RGB control
Summary

Initial inclusion

Test Plan

Install the package, make sure the i2c-dev module is loaded if you want to control a SMBus device and start the "run as root" desktop file

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Tzigamm created this revision.Apr 13 2020, 1:03 PM
Tzigamm requested review of this revision.Apr 13 2020, 1:03 PM
Tzigamm retitled this revision from Initial inclusion of OpenRGB, fixes T8560 Please note: I had to create /etc/OpenRGB/, it's empty when the package is installed but is needed as the "Path" argument of the desktop files. Removing this line, OpenRGB will save and load its profiles... to Initial inclusion of OpenRGB, fixes T8560.Apr 13 2020, 1:04 PM
Tzigamm edited the summary of this revision. (Show Details)

Just saw we could add a conf file in /etc/modules-load.d/ so the i2c-dev module would autoload, I'm guessing most user would use it that way, should I patch this diff with the conf file?

Tzigamm updated this revision to Diff 21038.Apr 30 2020, 12:50 PM

Fixed the need for creating an empty directory

Tzigamm edited the summary of this revision. (Show Details)Apr 30 2020, 12:51 PM
Tzigamm edited the summary of this revision. (Show Details)
Tzigamm updated this revision to Diff 21039.Apr 30 2020, 12:56 PM

Add the i2c-dev.conf file to /etc/modules-load.d/

DataDrake edited the summary of this revision. (Show Details)May 13 2020, 3:52 PM
DataDrake requested changes to this revision.May 13 2020, 3:54 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
7

Should be GPL-2.0-or-later or GPL-2.0-only according to the author's preference and in compliance with SPDX naming.

This revision now requires changes to proceed.May 13 2020, 3:54 PM
Tzigamm updated this revision to Diff 21456.May 20 2020, 1:42 PM

Update to 0.2, changed the license

Tzigamm marked an inline comment as done.May 20 2020, 1:42 PM

Hoping this will land soon. Want to get rid of the pulsing rainbows in my tower.

DataDrake requested changes to this revision.Jun 13 2020, 5:34 PM

Please add a MAINTAINERS.md file listing yourself as maintainer.

This revision now requires changes to proceed.Jun 13 2020, 5:34 PM
JoshStrobl requested changes to this revision.Jun 23 2020, 5:30 PM
JoshStrobl added a subscriber: JoshStrobl.

Any update on this?

Also your .solus/packager file needs to have your first name(s) and last name(s) for accountability purposes. It'll should up in the Update entry in the pspec once you update the file and rebuild.

Tzigamm updated this revision to Diff 22058.Jun 26 2020, 11:49 AM

Add MAINTAINERS.md

Tzigamm updated this revision to Diff 22059.Jun 26 2020, 11:54 AM

And updated pspec.xml, sorry about that

OpenRGB 0.3 has been released, I'd suggest updating the diff accordingly.

I'm also willing to take up maintainership of this package, should the need arise.

Speaking of the maintainers file, you should move the block with your name/email/IRC back by 4 spaces so your name is flush with the start of the line. They'll block review again if you don't fix it, I've seen it before ;)

Unknown Object (User) awarded a token.Aug 2 2020, 8:23 AM
Unknown Object (User) added a subscriber: Unknown Object (User).
Tzigamm updated this revision to Diff 22645.Aug 7 2020, 7:55 PM

Sorry about the delay, there's now a way to use OpenRGB as a daemon so I tested it for a while, now all the compromise I needed to do are gone!

PS: For anyone wanting to try it, you might want to start/enable the daemon, if you're not root/don't have the right permission some of your hardware might not appear

DataDrake requested changes to this revision.Dec 16 2020, 9:16 AM

@Tzigamm Are you still interested in maintaining this? Sorry it has taken us so long to review it.

This revision now requires changes to proceed.Dec 16 2020, 9:16 AM
JoshStrobl abandoned this revision.Jan 20 2021, 7:58 PM