Page MenuHomeSolus

Rebuild eiskaltdcpp against libboost 1.72.0
AbandonedPublic

Authored by algent on Apr 11 2020, 6:25 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8835: Update boost to 1.72.0
Summary

Rebuild for libboost 1.72.0

Depends on D8527
Reference task T8835

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan
  • Install & Run application
  • Share a folder
  • Connect to a Public Hub

Diff Detail

Repository
R687 eiskaltdcpp
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

algent created this revision.Apr 11 2020, 6:25 PM
algent requested review of this revision.Apr 11 2020, 6:25 PM
algent added a comment.EditedApr 11 2020, 6:29 PM

No idea why libboost dependency has gone. This is happening with libboost-1.72.0.
But libboost-devel is need to build it.
Rebuilding it with libboost-1.66.0 no change in abi_used_libs.
In both cases the patch fix-build-with-pango-1.44.patch is needed.

algent edited the test plan for this revision. (Show Details)Apr 11 2020, 9:16 PM
algent added a comment.EditedApr 12 2020, 12:10 PM

Worth mentioning here that there is an issue with search. It crashes a lot with Segmentation fault. This is already reported several times upstream. Issue1, Issue2, Issue3, Issue4 and maybe there are more.

If I am understanding well, the are planing to deprecate GUI.

algent edited the summary of this revision. (Show Details)Apr 22 2020, 8:46 AM
DataDrake accepted this revision.May 13 2020, 7:15 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.May 13 2020, 7:15 AM
kyrios123 edited the summary of this revision. (Show Details)Jun 18 2020, 5:12 PM
algent abandoned this revision.Jun 21 2020, 1:47 PM

Synced with git in e582c2491c00. Now it builds fine with libboost-devel version 1.72.0 but it doesn't add libboost as rundependency.