Page MenuHomeSolus

Updated Commit of QMMP to latest version
AbandonedPublic

Authored by melosaiyan on Apr 10 2020, 2:59 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T5356: Qmmp
Summary

The inclusion of qmmp fixes T5356

Signed-off-by: Brian Urbina <brian.urbina@outlook.com>

Test Plan

Played some audio tracks successfully

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

melosaiyan created this revision.Apr 10 2020, 2:59 PM
melosaiyan requested review of this revision.Apr 10 2020, 2:59 PM
DataDrake requested changes to this revision.Apr 12 2020, 5:34 PM
DataDrake added a subscriber: DataDrake.

You didn't bump the release number.

This revision now requires changes to proceed.Apr 12 2020, 5:34 PM

You didn't bump the release number.

hey thanks for the response! Should release number be 2 or 1.1? Not sure what the version convention should be.

algent added a subscriber: algent.EditedApr 13 2020, 12:50 PM

Yes the release number should be 2.
You have to run make bump to do that and then make to build the package.
Then install the package in your PC to test it.
Later run make clean to delete the eopkg file from that folder.
To submit the package run git commit --ammend and arc diff.

Yes the release number should be 2.
You have to run make bump to do that and then make to build the package.
Then install the package in your PC to test it.
Later run make clean to delete the eopkg file from that folder.
To submit the package run git commit --ammend and arc diff.

Thanks! I appreciate the feedback. I'll make an update and re-do the commit.

I bumped the release number but then got a dependency error that the libvorbis release needed to be >= 12 and currently there's release 11 out there. I don't remember seeing this before and building with QMMP 1.3.6 gave the same error. What would be the cause of this dependency change? Is there a way to request a new release to be added for libvorbis?

It is reporting correctly. libvorpis was rebuilded today. Authored by DataDrake on Mon, Apr 13, 7:07 AM. Release it is 12. https://dev.getsol.us/source/libvorbis/

It is reporting correctly. libvorpis was rebuilded today. Authored by DataDrake on Mon, Apr 13, 7:07 AM. Release it is 12. https://dev.getsol.us/source/libvorbis/

Oh I see so it was updated today. How do I go about getting release 12 or is that something I would need to wait for? Apologize for the newbie question.

You have to be in Unstable repository, if you want to do packaging.
sudo eopkg ar Solus https://mirrors.rit.edu/solus/packages/unstable/eopkg-index.xml.xz
Just do a normal update. Atm don't update. Always take a look at #Solus-Dev the IRC channel to see when it is not recommended to update.
Also check this page for some other info.

melosaiyan updated this revision to Diff 20797.Apr 13 2020, 3:16 PM

Updated QMMP install to next release version

Bumped up the release version to the package.yml file

You have to be in Unstable repository, if you want to do packaging.
sudo eopkg ar Solus https://mirrors.rit.edu/solus/packages/unstable/eopkg-index.xml.xz
Just do a normal update. Atm don't update. Always take a look at #Solus-Dev the IRC channel to see when it is not recommended to update.
Also check this page for some other info.

Appreciate all the useful information, thank you. I made the updated and will review the documentation you provided for future reference.

algent added a comment.EditedApr 13 2020, 3:30 PM

Looking more to this. qmmp was never included in repo so you can't update it like this.
Ju have to update the old diff.

At the moment this revision is wrong.
https://dev.getsol.us/D8150 Here is you first work. Why didn't you continue this?

At the moment this revision is wrong.
https://dev.getsol.us/D8150 Here is you first work. Why didn't you continue this?

I attempted to continue the first work to update to the latest qmmp but for some reason I could not commit to D8150. When I did the arc diff it created this new one, D8649. I'd like to continue the first work but now that I created this new version, I'll have to figure out how to continue the first work and invalidate this one, to avoid confusion.

That is why you should pay attention to Solus Packaging Documentation to avoid issues like this when submitting a package. It is not that difficult. See how other people are doing their changes and ask for help in IRC channel for things that you don't understand.
About these D8649 and D8150 one of them should be abandoned.

That is why you should pay attention to Solus Packaging Documentation to avoid issues like this when submitting a package. It is not that difficult. See how other people are doing their changes and ask for help in IRC channel for things that you don't understand.
About these D8649 and D8150 one of them should be abandoned.

I've read the documentation for building a package several times and watched the Solus videos where Josh goes through a patch as well so it was straightforward for me. My revisions worked fine until I was attempting to make updates after taking a break from updating my package where I don't know how to deal with issues with arc diff. I didn't utilize the IRC chat to ask for help so I will do this next time I come across issues. I really appreciate your help with everything. I do want to contribute and hope to be better with my patches. The Solus community is amazing :)

DataDrake requested changes to this revision.Apr 15 2020, 4:22 AM
DataDrake added inline comments.
package.yml
10

Should not be using 80 column wrapping.

This revision now requires changes to proceed.Apr 15 2020, 4:22 AM
DataDrake abandoned this revision.May 13 2020, 4:36 PM

Should be updating the original revision. Sorry I missed that.

algent removed a subscriber: algent.May 13 2020, 4:39 PM