Paths

Table of Contentst

Differential D8603

Update uncrustify to 0.70.1
ClosedPublic
Actions

Authored by silke on Apr 1 2020, 3:12 PM.

Tags

None

Referenced Files

	F11065610: D8603.diff
	Fri, Aug 11, 5:07 PM

	F11022625: D8603.id20563.diff
	Tue, Aug 8, 3:07 AM

	F10978841: D8603.id20586.diff
	Sat, Jul 22, 9:03 PM

	F10888910: D8603.id20563.diff
	Jun 27 2023, 10:22 AM

	F10888580: D8603.id20586.diff
	Jun 27 2023, 4:56 AM

	F10886176: D8603.id20564.diff
	Jun 25 2023, 7:22 PM

	F10886031: D8603.id20585.diff
	Jun 25 2023, 5:41 PM

	F10885145: D8603.diff
	Jun 25 2023, 7:56 AM

View All 10 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R3079:13cd603dcbe3: Update uncrustify to 0.70.1

Summary

Update uncrustify to 0.70.1.
Changelog available here

Test Plan

Run uncrustify on some C code.

Diff Detail

Repository

R3079 uncrustify

Branch

arcpatch-D8603

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

silke created this revision.Apr 1 2020, 3:12 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptApr 1 2020, 3:12 PM

silke requested review of this revision.Apr 1 2020, 3:12 PM

Fix SPDX license identifier

JoshStrobl requested changes to this revision.Apr 2 2020, 5:44 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
15	Let's clean this up while we're reviewing. Can be `%make -C build` and nuke the `cd build`
17	Let's clean this up while we're reviewing. Can be `%make_install -C build` and nuke the `cd build`

This revision now requires changes to proceed.Apr 2 2020, 5:44 AM

Update setup/build/install commands

silke marked an inline comment as done.Apr 2 2020, 5:36 PM

silke added inline comments.

package.yml
15	Good point. I switched the entire build to cmake/ninja, as that seems to work fine.

silke marked an inline comment as done.Apr 2 2020, 5:36 PM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 2 2020, 5:57 PM

Closed by commit R3079:13cd603dcbe3: Update uncrustify to 0.70.1 (authored by silke, committed by JoshStrobl). · Explain WhyApr 2 2020, 5:57 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R3079:13cd603dcbe3: Update uncrustify to 0.70.1.

Revision Contents
Changeset List

Path

Size

18 lines

pspec_x86_64.xml

39 lines

Diff 20585

package.yml

Loading...

pspec_x86_64.xml

Loading...