Page MenuHomeSolus

Initial commit of wsjtx
AbandonedPublic

Authored by w2nap on Mar 27 2020, 11:35 PM.

Details

Reviewers
Girtablulu
Group Reviewers
Triage Team
Summary

wsjtx ham radio weak signal mode software request per T8659

Test Plan

test by me and william stearns NE4RD

Package installed no issue.
Package starts no issue
Able to edit settings that are editable.
Decodes of weak signal modes working.
sending of the data tones working.
log ability works as it should.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

w2nap created this revision.Mar 27 2020, 11:35 PM
w2nap requested review of this revision.Mar 27 2020, 11:35 PM
Girtablulu retitled this revision from Initial commit of wsjtx new file: Makefile new file: package.yml new file: pspec_x86_64.xml to Initial commit of wsjtx.Mar 27 2020, 11:53 PM
w2nap retitled this revision from Initial commit of wsjtx to Initial commit of wsjtx new file: Makefile new file: package.yml new file: pspec_x86_64.xml.Mar 28 2020, 12:00 AM
w2nap edited the test plan for this revision. (Show Details)
Girtablulu requested changes to this revision.Mar 28 2020, 12:05 AM
Girtablulu added a subscriber: Girtablulu.

No abi files generated?

package.yml
7

remove the # check me

12

Buildeps should be in alphabetical order, with pkgconfigs() coming first

13

for what is this needed?

14

isn't this a mac dep?

15

isn't this a mac dep?

16

use the pkgconfig

18

not needed due rev deps

20

use the pkgconfig

21

use the pkgconfig

22

remove empty line

24

remove empty line

27

remove empty line

30

remove empty line

This revision now requires changes to proceed.Mar 28 2020, 12:05 AM
w2nap updated this revision to Diff 20503.Mar 28 2020, 12:58 AM
  1. Updating D8570: Initial commit of wsjtx new file: Makefile new file: package.yml new file: pspec_x86_64.xml #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

Package.yml update
cleaned up builddeps
git needed for pulling wsjtx patched hamlib from wsjtx-dev git
textinfo asciidoc needed for building of manual, without package will not build.

Girtablulu requested changes to this revision.Mar 28 2020, 11:42 AM

Why did you add the patch file? this is not needed

package.yml
17

you pull in qt5-tools-devel in twice, with UiPlugin and UiTools you only need to mention this once

20

For what are the builddeps git and texinfo needed on Linux build?

21

remove empty line

This revision now requires changes to proceed.Mar 28 2020, 11:42 AM
Girtablulu retitled this revision from Initial commit of wsjtx new file: Makefile new file: package.yml new file: pspec_x86_64.xml to Initial commit of wsjtx.Mar 28 2020, 11:42 AM
DataDrake abandoned this revision.Wed, May 13, 4:39 PM
DataDrake added a subscriber: DataDrake.

Abandoning due to lack of activity in over 30 days.