Page MenuHomeSolus

Update vulkan-headers to 1.2.135
AbandonedPublic

Authored by sethfl on Mar 26 2020, 1:58 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Maniphest Tasks
T8849: Update Vulkan-Loader to 1.2.135 (for Doom Eternal)
Summary

Update vulkan-headers to 1.2.135, part 1 of resolving T8849. (This is needed to be commited in order to build vulakn 1.2.135 to fully resolve T8849)

Changelog: Can be found here

Test Plan
  • Build vulkan against this package

Diff Detail

Repository
R4419 vulkan-headers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

sethfl created this revision.Mar 26 2020, 1:58 PM
sethfl requested review of this revision.Mar 26 2020, 1:58 PM
JoshStrobl abandoned this revision.Mar 26 2020, 1:59 PM
JoshStrobl added subscribers: kyrios123, JoshStrobl.

They don't have an SDK release out. Please leave this to @kyrios123 and Core Team, thanks.

@JoshStrobl I understand leaving this to the core team, but why base the release off of the SDK? According to the upstream github releases, SDK releases are very scattered and do not release for every version, and in turn, do not give users performance improvements such as those mentioned in T8849 for a while. Wouldn't it be better to release the SDK as a vulkan-devel package and rebase the vulkan package on the standard release in order to give end users performance improvements faster? Just kinda wondering 🤔

@sethfl These are just headers. The benefits of any changes are only realized when the libraries that use them are updated. The most important of which being Mesa which hasn't incorporated these changes yet.

sethfl added a comment.EditedMar 26 2020, 4:35 PM

@DataDrake I'm not sure if I understand you correctly. Mesa has to incorporate changes from upstream vulkan? If so, I see what you mean about rebasing on a standard release being pointless. However, couldn't a more up-to-date vulkan-loader lib still increase performance along with mesa, or allow for more to date features (such as ray tracing, since it was introduced in 1.2.135)? Or could mesa use the newly introduced features from updated spec with an outdated vulkan-loader SDK?

but why base the release off of the SDK? According to the upstream github releases, SDK releases are very scattered and do not release for every version, and in turn, do not give users performance improvements such as those mentioned in T8849 for a while.

Because the tagged release don't have the same quality as the SDK. Also the issue you refer to as a justification is still open and if you look at a more recent comment, they say it requires vulkan header/loader 1.2 which we already have.

Personally I see zero interest running after the tagged releases. As @DataDrake underlined vulkan is just one piece of the puzzle if the remaining pieces aren't updated you won't get any benefit of it.

@kyrios123 alright I understand now. Thanks for your response!