Page MenuHomeSolus

Update libgusb to 0.3.4 and build against modern toolchain
ClosedPublic

Authored by Jacalz on Mar 24 2020, 5:38 PM.

Details

Summary

Changelog:

  • This fixes the symbol version for g_usb_version_string() to be in the right place.
  • Validate the exported symbol list during check.
  • Include the USB bus in the generated platform_id.
  • Add a thin glib wrapper around libusb_endpoint_descriptor.
  • Fix high number of wakeups when checking the GUsbContext.
  • Use '#pragma once' to reduce boilerplate.
  • Wrap the upstream libusb_strerror().
  • Do not use deprecated libusb API.
  • Use has_link_argument() to detect linker flags.
  • Add g_usb_device_get_spec().
  • Add g_usb_version_string() for fwupd.
  • Add -Wswitch-enum.
  • Fix GI length introspection annotations.
  • Make gir generation optional.
Test Plan
  • Rebuild gnome-multi-writer and use it to flash the Solus Gnome iso.

Diff Detail

Repository
R1725 libgusb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Mar 24 2020, 5:38 PM
Jacalz requested review of this revision.Mar 24 2020, 5:38 PM
Jacalz retitled this revision from Update libgusb to 0.3.4 to Update libgusb to 0.3.4 and build against moder toolchain.Mar 24 2020, 7:57 PM
Jacalz retitled this revision from Update libgusb to 0.3.4 and build against moder toolchain to Update libgusb to 0.3.4 and build against modern toolchain.
DataDrake requested changes to this revision.Apr 12 2020, 5:49 PM
DataDrake added a subscriber: DataDrake.

Need to test simple-scan and colord because of deleted symbols.

This revision now requires changes to proceed.Apr 12 2020, 5:49 PM

I have rebuilt colord and simple-scan against this version without issues. I can't test simple-scan because I have no scanner, camera or anything along those lines.
I installed libgusb since colord is required by gtk3 and I don't see anything that isn't working as expected.

DataDrake accepted this revision.Wed, May 13, 4:38 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Wed, May 13, 4:38 PM
This revision was automatically updated to reflect the committed changes.