Page MenuHomeSolus

Update to 4.2.0, fixes T8841
ClosedPublic

Authored by sethfl on Mar 24 2020, 12:37 PM.

Details

Summary

Updated Source URL/SHA256SUM in package.yml. Resolves T8841.

Changlog: https://raw.githubusercontent.com/getpelican/pelican/master/docs/changelog.rst

Test Plan
  • Built against unstable
  • Install packages locally with unstable enviorment
  • Test basic commands
  • Test user made templates/configurations
  • Test uninstall process

Diff Detail

Repository
R4576 pelican
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sethfl created this revision.Mar 24 2020, 12:37 PM
sethfl requested review of this revision.Mar 24 2020, 12:37 PM
sethfl added a subscriber: sethfl.Mar 24 2020, 12:41 PM
DataDrake requested changes to this revision.Mar 24 2020, 1:02 PM
DataDrake added a subscriber: DataDrake.

Looks like you based this on an old commit since the python version changed. The Summary should include a changelog from upstream to indicate what new things users can expect in this release.

This revision now requires changes to proceed.Mar 24 2020, 1:02 PM
sethfl updated this revision to Diff 20412.Mar 24 2020, 3:36 PM

Update to 4.2.0, fixes T8841

Summary: Updated Source URL/SHA256SUM in package.yml

Changelog: https://raw.githubusercontent.com/getpelican/pelican/master/docs/changelog.rst

Test Plan:

  • Build locally against unstable
  • Install generated .eopkg
  • Use basic commands

@DataDrake It should have been built with the correct python version this time. Let me know if I am mistaken. I also updated the summary with the upstream change log.

@sethfl You need to make your changes to the summary by clicking Edit Revision and updating the text.

Also, I need to see more of a test plan. Installing is insufficient.

DataDrake requested changes to this revision.Mar 24 2020, 5:25 PM
This revision now requires changes to proceed.Mar 24 2020, 5:25 PM
sethfl edited the summary of this revision. (Show Details)Mar 25 2020, 1:44 AM
sethfl edited the test plan for this revision. (Show Details)

@DataDrake I updated the summary per your request.

sethfl updated this revision to Diff 20459.Mar 26 2020, 10:18 AM
sethfl edited the summary of this revision. (Show Details)

revised again.

JoshStrobl requested changes to this revision.Mar 26 2020, 2:05 PM
JoshStrobl added a subscriber: JoshStrobl.

This needs to be against master branch not your arc patch branch. Please make sure you are properly squashing your commits and basing your work against master.

This revision now requires changes to proceed.Mar 26 2020, 2:05 PM
sethfl updated this revision to Diff 20481.Mar 26 2020, 2:57 PM

rebuilt against master branch.

DataDrake accepted this revision.Apr 13 2020, 2:31 AM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2020, 2:32 AM
Closed by commit R4576:3ae9dd38a621: Update to 4.2.0, fixes T8841 (authored by sethfl, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.