Differential D8523

Update binaryen to 91
ClosedPublic
Actions

Authored by YakoYakoYokuYoku on Mar 20 2020, 8:18 PM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Commits

R4920:58510099d82c: Update binaryen to 91

Summary

The new version introduces the following changes:

BinaryenExpressionGetSideEffects (C API) and getSideEffects (JS API) now takes an additional features parameter.
Reference type support is added. Supported instructions are ref.null, ref.is_null, ref.func, and typed select. Table instructions are not supported yet. For typed select, C/JS API can take an additional 'type' parameter.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Compiled this example of WebGL with Emscripten.

Diff Detail

Repository

R4920 binaryen

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

YakoYakoYokuYoku created this revision.Mar 20 2020, 8:18 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 20 2020, 8:18 PM

YakoYakoYokuYoku requested review of this revision.Mar 20 2020, 8:18 PM

YakoYakoYokuYoku added a child revision: D7654: Initial commit of emscripten.Mar 20 2020, 8:21 PM

Removed git from build deps

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 12 2020, 5:58 PM

Rebase:

This diff is against commit d735915ceacd766f178c4263a686cfdb87a53492 \
    D7652, but the commit is nowhere in the working copy. Try to apply it
    against the current working copy state?

This revision now requires changes to proceed.Apr 12 2020, 5:59 PM