Page MenuHomeSolus

Update binaryen to 91
ClosedPublic

Authored by YakoYakoYokuYoku on Mar 20 2020, 8:18 PM.

Details

Summary

The new version introduces the following changes:

  • BinaryenExpressionGetSideEffects (C API) and getSideEffects (JS API) now takes an additional features parameter.
  • Reference type support is added. Supported instructions are ref.null, ref.is_null, ref.func, and typed select. Table instructions are not supported yet. For typed select, C/JS API can take an additional 'type' parameter.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Compiled this example of WebGL with Emscripten.

Diff Detail

Repository
R4920 binaryen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Mar 20 2020, 8:18 PM

Removed git from build deps

DataDrake accepted this revision.Apr 12 2020, 5:58 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 12 2020, 5:58 PM
DataDrake requested changes to this revision.Apr 12 2020, 5:59 PM

Rebase:

This diff is against commit d735915ceacd766f178c4263a686cfdb87a53492 \
    D7652, but the commit is nowhere in the working copy. Try to apply it
    against the current working copy state?
This revision now requires changes to proceed.Apr 12 2020, 5:59 PM

Maybe this will work (???). Pulled and rebased the changes.

DataDrake accepted this revision.Apr 12 2020, 8:24 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 12 2020, 8:24 PM
This revision was automatically updated to reflect the committed changes.