Page MenuHomeSolus
Differential D8522

Initial commit of closure-compiler
ClosedPublic
Actions

Authored by YakoYakoYokuYoku on Mar 20 2020, 7:52 PM.
Tags
None
Referenced Files
F11021538: D8522.diff
Mon, Aug 7, 3:24 PM
F11013181: D8522.id20768.diff
Fri, Aug 4, 10:59 AM
F10945811: D8522.id.diff
Sat, Jul 15, 5:53 AM
F10850448: D8522.id20764.diff
Jun 12 2023, 4:09 AM
F10846275: D8522.id20768.diff
Jun 11 2023, 4:12 AM
F10846162: D8522.id20378.diff
Jun 11 2023, 3:47 AM
F10843309: D8522.id20375.diff
Jun 10 2023, 5:28 PM
F10825995: D8522.diff
Jun 4 2023, 1:42 AM
View All 12 Files
Subscribers
DataDrake

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T3098: Emscripten
Commits
R4954:68b61bda1655: Initial commit of closure-compiler
Summary

The inclusion of closure-compiler fixes T3098.
It's a rundep of emscripten built separetedly.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Built a wasm module with emcc --closure 1

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

YakoYakoYokuYoku created this revision.Mar 20 2020, 7:52 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptMar 20 2020, 7:52 PM
YakoYakoYokuYoku requested review of this revision.Mar 20 2020, 7:52 PM
YakoYakoYokuYoku added a child revision: D7654: Initial commit of emscripten.Mar 20 2020, 8:21 PM
YakoYakoYokuYoku updated this revision to Diff 20378.Mar 20 2020, 8:36 PM

Fix the permissions

DataDrake requested changes to this revision.Apr 12 2020, 6:04 PM
DataDrake added a subscriber: DataDrake.

Please use the full path to java within openjdk-8's directory rather than relying on the symlink in /usr/bin. That will be going away.

This revision now requires changes to proceed.Apr 12 2020, 6:04 PM
YakoYakoYokuYoku updated this revision to Diff 20764.Apr 13 2020, 2:18 AM

Don't use the symlink, use the direct path and update to version 20200406.

DataDrake accepted this revision.Apr 13 2020, 2:29 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 13 2020, 2:29 AM
Closed by commit R4954:68b61bda1655: Initial commit of closure-compiler (authored by YakoYakoYokuYoku, committed by DataDrake). · Explain WhyApr 13 2020, 2:32 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4954:68b61bda1655: Initial commit of closure-compiler.

Revision Contents
Changeset List

PathSize
1 line
files/
3 lines
3 lines
28 lines
38 lines

Diff 20764

View Options

Makefile

Loading...
View Options

files/closure-compiler

Loading...
View Options

files/closure-compiler-linter

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.