Page MenuHomeSolus

Initial commit of closure-compiler
ClosedPublic

Authored by YakoYakoYokuYoku on Mar 20 2020, 7:52 PM.

Details

Summary

The inclusion of closure-compiler fixes T3098.
It's a rundep of emscripten built separetedly.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Built a wasm module with emcc --closure 1

Diff Detail

Repository
R4954 closure-compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Mar 20 2020, 7:52 PM

Fix the permissions

DataDrake requested changes to this revision.Apr 12 2020, 6:04 PM
DataDrake added a subscriber: DataDrake.

Please use the full path to java within openjdk-8's directory rather than relying on the symlink in /usr/bin. That will be going away.

This revision now requires changes to proceed.Apr 12 2020, 6:04 PM

Don't use the symlink, use the direct path and update to version 20200406.

DataDrake accepted this revision.Apr 13 2020, 2:29 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 13 2020, 2:29 AM
This revision was automatically updated to reflect the committed changes.