Page MenuHomeSolus

Update usb-modeswitch to 2.6.0
Needs RevisionPublic

Authored by livingsilver94 on Sat, Mar 14, 9:27 PM.

Details

Summary

Rewrote parts of the dispatcher script to make location of global config file into a parameter: --config-file, so it can be customised now.

Fixes T7380.

Test Plan

Pending.

Diff Detail

Repository
R3094 usb-modeswitch
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

livingsilver94 created this revision.Sat, Mar 14, 9:27 PM
livingsilver94 requested review of this revision.Sat, Mar 14, 9:27 PM
livingsilver94 edited the summary of this revision. (Show Details)EditedSat, Mar 14, 9:27 PM

I don't have a USB modem to test right now. For tests, wait for me to get one or please go ahead and test my patch.

JoshStrobl requested changes to this revision.Thu, Mar 19, 4:54 PM
JoshStrobl added a subscriber: JoshStrobl.

Otherwise LGTM

package.yml
25

Couldn't we just do rm -rf $installdir/var ?

This revision now requires changes to proceed.Thu, Mar 19, 4:54 PM
livingsilver94 added inline comments.Thu, Mar 19, 6:21 PM
package.yml
25

I want to make sure we'd not delete anything useful, rmdir in fact would throw an error. Do you still want me to use rm?