Page MenuHomeSolus

Initial commit of font-jetbrains-mono-ttf
AbandonedPublic

Authored by maveonair on Fri, Mar 13, 12:43 PM.

Details

Reviewers
ikeycode
Group Reviewers
Triage Team
Maniphest Tasks
T8818: JetBrains Mono Font
Summary

Initial commit of Jetbrains Mono Fonts

Test Plan

Used in GNOME Temrinal

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

maveonair created this revision.Fri, Mar 13, 12:43 PM
maveonair requested review of this revision.Fri, Mar 13, 12:43 PM
maveonair updated this revision to Diff 20293.
maveonair retitled this revision from Initial commit to Initial commit of font-jetbrains-mono-ttf.

Improve commit message

ikeycode requested changes to this revision.Fri, Mar 13, 12:45 PM
ikeycode added a subscriber: ikeycode.

Apart from the incorrect version the patch looks OK - just wondering though has there been a packaging request for this

package.yml
3

Version needs to match upstream version, which is 1.0.3

This revision now requires changes to proceed.Fri, Mar 13, 12:45 PM
maveonair updated this revision to Diff 20294.Fri, Mar 13, 12:46 PM

Set correct version number

ikeycode resigned from this revision.Fri, Mar 13, 12:47 PM

From my perspective it looks ok now, so I'll hand off to the team.

Apart from the incorrect version the patch looks OK - just wondering though has there been a packaging request for this

Thanks for the review.

I am very new to Solus and I probably misunderstood that there has to be a package request before a package can be submitted?

Usually as it just makes life easier for the team, basically its a "why do we need this" justification. i.e. what value does it add, can it be distributed, that kinda thing. Then we typically
link a diff to the issue to make it easier to see what problem the patch solves. Welcome though, nice first contribution. I know the process can sometimes be awkward but its just a case
of transparency and documentation :)

maveonair marked an inline comment as done.Fri, Mar 13, 12:53 PM

Thank you for the clarification. So this means I should create now a package request and link this submission to the request if I understood it correctly?

Exactly :) should be some links in the sidebar on how to do this. Just think of it as boring accounting xD

kyrios123 abandoned this revision.Fri, Mar 13, 3:29 PM
kyrios123 added a subscriber: kyrios123.

Don't submit patches for tasks that haven't been approved.
Thanks.

Read the thread @kyrios123, I guided the user to create a task. Abandoning the revision is super hostile, given the context, and wastes everyones time.

Read the thread @kyrios123, I guided the user to create a task. Abandoning the revision is super hostile, given the context, and wastes everyones time.

Thanks for guiding the user !
You see hostility where there isn't. We would all waste time if we had to leave patches for which no request has been approved in the queue. The user is welcome to submit the patch again once the request is approved.

https://getsol.us/articles/packaging/submitting-a-package/en/#prior-to-patch-submission