Do you want to enable dbus for dnsmasq? Most distros have it enabled, though I'm not sure what's useful for. Configuration maybe?

EDIT ah yes, here it is: https://github.com/imp/dnsmasq/blob/master/dbus/DBus-interface

Oh, I found this task: T7032

You can review now. There's still a little issue to fix imho: dnsmasq is launched with nobody user, in fact I get mar 13 19:31:17 phoenix dnsmasq[30598]: chown of PID file /var/run/NetworkManager/dnsmasq.pid failed: Operation not permitted when NetworkManager launches dnsmasq. Other distros add a system user dedicated to it, let me say what you want me to do.

Also, I think that putting dnsmasq inside /usr/bin is incorrect. It requires to create sockets in order to work, so I think the default path, /usr/sbin, is better.

I don't really understand why we need it to be dbus enabled. I have this running on my server without dbus enabling and it is integrated into NetworkManager without issue. The dnsmasq binary (/usr/sbin/dnsmasq) is run as dnsmasq user, however our NetworkManager is run as root (it is on my Fedora Server box as well) so I don't really see a need for a dedicated user instead of running it as root.

@JoshStrobl you sure DBUS is not needed? By adding /etc/NetworkManager/conf.d/00-enable-dnsmasq.conf with the following content:

[main]
dns=dnsmasq

I get, with sudo systemctl status NetworkManager.service:

mag 14 22:43:43 phoenix NetworkManager[2937]: dnsmasq: DBus not available: set HAVE_DBUS in src/config.h
mag 14 22:43:43 phoenix dnsmasq[2937]: DBus not available: set HAVE_DBUS in src/config.h
mag 14 22:43:43 phoenix dnsmasq[2937]: FAILED to start up
mag 14 22:43:43 phoenix NetworkManager[2742]: <warn>  [1589489023.3626] dnsmasq: spawn: dnsmasq process 2937 exited with error: Configuration problem (1)
mag 14 22:43:43 phoenix NetworkManager[2742]: <info>  [1589489023.3628] dnsmasq: starting /usr/bin/dnsmasq
mag 14 22:43:43 phoenix NetworkManager[2938]: dnsmasq: DBus not available: set HAVE_DBUS in src/config.h
mag 14 22:43:43 phoenix dnsmasq[2938]: DBus not available: set HAVE_DBUS in src/config.h
mag 14 22:43:43 phoenix dnsmasq[2938]: FAILED to start up
mag 14 22:43:43 phoenix NetworkManager[2742]: <warn>  [1589489023.3646] dnsmasq: spawn: dnsmasq process 2938 exited with error: Configuration problem (1)
mag 14 22:43:43 phoenix NetworkManager[2742]: <warn>  [1589489023.3648] dnsmasq[196fd76a30cab2df]: dnsmasq dies and gets respawned too quickly. Back off.

Which is the exact error reported in T7032.

Yea I looked into it further on the Fedora side of things and I was indeed incorrect. Still not entirely sure if we should opt to have dnsmasq via sysusers, if that's something you want to tinker with so it has access to that PID you're more than welcome to.

If that's something you want to tinker with so it has access to that PID you're more than welcome to.

Yeah I figured out how to change the user @JoshStrobl. So you want root, right?

Although I think it's a better practice to create a dedicated user. dnsmasq starts as root and then falls back to nobody for security reasons (?). Giving it a dedicated user would allow it to behave while not being exposed to too many privileges.

I don't have a strong preference on the matter. A sysuser is probably sufficient.