Initial packaging of iputils s20190709
ClosedPublic
Actions

Authored by silke on Mar 9 2020, 9:53 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T8801: iputils

Commits

R4960:47f69be1aa7b: Initial packaging of iputils s20190709

Summary

The ping command has been renamed to iputils-ping in order to avoid conflicts with inetutils.

Depends on D8461
Resolves T8801

Test Plan

Executed the following successfully:

arping -c 4 $host
clockdiff $host
iputils-ping -4 -c 4 $host
iputils-ping -6 -c 4 $host

tracepath -4 transip.nl
tracepath -6 transip.nl
traceroute6 transip.nl

systemctl start ninfod
iputils-ping -c1 -6 -N node localhost

rarpd, rdisc and tftpd are untested.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

silke created this revision.Mar 9 2020, 9:53 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 9 2020, 9:53 PM

silke requested review of this revision.Mar 9 2020, 9:53 PM

Some binaries could really use CAP_NET_RAW, not sure how to set that it in package.yml though (as this is stripped in the package).

JoshStrobl requested changes to this revision.Apr 15 2020, 2:48 PM

JoshStrobl edited the summary of this revision. (Show Details)

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
6	This needs to be a list not a comma-separated string
11	Why is networking needed?
16	pkgconfigs should be above static builddeps

This revision now requires changes to proceed.Apr 15 2020, 2:50 PM

Fix networking, license and builddeps ordering

silke added inline comments.Apr 17 2020, 4:15 PM

package.yml
6	Ack. I have also updated the license for rdisc, which is `Rdisc`, not `AS-IS`.
11	It isn't, this is a leftover from some debugging. I have removed it.

JoshStrobl requested changes to this revision.Apr 26 2020, 12:45 PM

JoshStrobl added inline comments.

package.yml
8	This is not a valid SPDX 3.0 identifier: https://spdx.org/licenses/ Should be GPL-2.0-or-later
9	This is not a valid SPDX 3.0 identifier: https://spdx.org/licenses/ Should be BSD-3-Clause