Paths

Table of Contentst

Differential D8454

Initial commit of networkmanager-strongswan
ClosedPublic
Actions

Authored by maveonair on Mar 8 2020, 6:33 PM.

Tags

None

Referenced Files

	F11006321: D8454.diff
	Tue, Aug 1, 2:48 PM

	F10878988: D8454.id20846.diff
	Jun 21 2023, 5:16 PM

	F10878196: D8454.id20784.diff
	Jun 21 2023, 5:15 AM

	F10877522: D8454.id20257.diff
	Jun 20 2023, 8:25 PM

	F10877269: D8454.id20239.diff
	Jun 20 2023, 5:34 PM

	F10877112: D8454.id20248.diff
	Jun 20 2023, 4:08 PM

	F10876788: D8454.id20249.diff
	Jun 20 2023, 1:17 PM

	F10875329: D8454.id20429.diff
	Jun 20 2023, 5:18 AM

View All 13 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T5016: networkmanager-strongswan

Commits

R4972:253862d3d066: Initial commit of networkmanager-strongswan

Summary

Initial commit of networkmanager-strongswan

Test Plan

Tested with a IPSEC vpn connection

Diff Detail

Repository

R4972 networkmanager-strongswan

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

maveonair created this revision.Mar 8 2020, 6:33 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 8 2020, 6:33 PM

maveonair requested review of this revision.Mar 8 2020, 6:33 PM

This package requires https://dev.getsol.us/D8453

maveonair mentioned this in T5016: networkmanager-strongswan.Mar 8 2020, 6:36 PM

Improve summary and description

Improve description

Use the same component name as other NetworkManager plugins in Solus

Jacalz added a subscriber: Jacalz.Mar 10 2020, 9:00 AM

Jacalz added inline comments.

package.yml
7	License should be `GPL-2.0-or-later` unless `GPL-2.0-only` is specified by the authors.

Update license according to review

maveonair added a task: T5016: networkmanager-strongswan.Mar 13 2020, 9:01 PM

maveonair added a parent revision: D8453: Initial commit of strongswan.

maveonair removed a parent revision: D8453: Initial commit of strongswan.Mar 13 2020, 9:04 PM

Update to version 1.5.0

DataDrake requested changes to this revision.Apr 12 2020, 7:49 PM

DataDrake added a subscriber: DataDrake.

DataDrake added inline comments.

package.yml
13	Please clean remove any of these that are dependencies of something else in the list. The remaining ones should also be ordered alphabetically.

This revision now requires changes to proceed.Apr 12 2020, 7:49 PM

maveonair added inline comments.Apr 13 2020, 7:23 AM

package.yml
13	Unfortunately, all these dependencies are required to build the package. Which one of those do you think are not required to be specified here? For instance, I just tried to remove the `pkgconfig(gtk+-3.0)` and the package failed to build.

Order dependencies alphabetically

pkgconfig(nm) is redundant because pkgconfig(nma) pulls it in.

This revision now requires changes to proceed.Apr 15 2020, 4:31 AM

Remove redundant dependency

@DataDrake does it look good now?

LGTM. Thanks!

This revision is now accepted and ready to land.May 13 2020, 8:37 AM

Closed by commit R4972:253862d3d066: Initial commit of networkmanager-strongswan (authored by maveonair, committed by DataDrake). · Explain WhyMay 13 2020, 8:39 AM

This revision was automatically updated to reflect the committed changes.

DataDrake added a commit: R4972:253862d3d066: Initial commit of networkmanager-strongswan.

Revision Contents
Changeset List

Path

Size

1 line

7 lines

28 lines

pspec_x86_64.xml

39 lines

Diff 21289

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...