Page MenuHomeSolus

Update Cinelerra-GG for 2020.02.29
ClosedPublic

Authored by Jacek on Mar 2 2020, 11:23 PM.

Details

Summary

Changelog:

  • New Coolorspace plugin
  • Option to edit a File by Reference
  • A lot of usability improvements and bugfixes

Full changelog available here

Test Plan

Edited a video and rendered a video a few different formats.

Diff Detail

Repository
R4773 cinelerra-gg
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacek created this revision.Mar 2 2020, 11:23 PM
Jacek requested review of this revision.Mar 2 2020, 11:23 PM
Jacek edited the test plan for this revision. (Show Details)Mar 3 2020, 9:22 AM
JoshStrobl added inline comments.
abi_used_libs
25

Are they no longer linking against lilv or using our system one? Same goes for suil.

JoshStrobl requested changes to this revision.Mar 8 2020, 4:07 PM
This revision now requires changes to proceed.Mar 8 2020, 4:07 PM

Also this needs to be rebased (sorry)

Jacek added a comment.Mar 8 2020, 5:30 PM

Oh, phabricator didn't submit my comment from 5 days ago...
So what should I do? Can we proceed like it is, or should I update those 3 dependencies so Cinelerra is less static? Will I need to create a local repo for that?

abi_used_libs
25

They updated minimum required versions of those packages, so now those is Solus repos are too old. Thats why it builds them staticially. Should request an update of lilv, suil and iec?

Jacek updated this revision to Diff 20245.EditedMar 9 2020, 5:05 PM
  • Update Cinelerra-GG to 2020.02.29

I'm working on it

Jacek updated this revision to Diff 20246.Mar 9 2020, 5:36 PM

Rebased and incremented the build number
I hope I did it correctly

In D8417#135841, @Jacek wrote:

Rebased and incremented the build number
I hope I did it correctly

Nope :(
You have to start from the latest remote commit

Jacek added a comment.Mar 9 2020, 6:19 PM

@kyrios123 Do I need to make a new diff? Any tips would be helpful

In D8417#135844, @Jacek wrote:

@kyrios123 Do I need to make a new diff? Any tips would be helpful

Mmmhh if you aren't a git guru, the easy workaround is

  • rename the repo into somthing else to backup your work
  • clone the repo again
  • copy the files from the renamed repo into the newly cloned repo
  • delete the renamed repo since you don't need it anymore
  • continue normally
Jacek added a comment.Mar 9 2020, 11:35 PM

But this will create a new diff on phabricator, won't it?

arc diff --update D8417

Jacek updated this revision to Diff 20260.Mar 10 2020, 9:43 AM

Rebase properly and up the version number

I think this package can stay as it is, but if next time I would need newer versions of some dependencies, then what steps should I take:

  1. Create a package update requests for each dependency, one for all or can I straight up post the updated diffs?
  2. If other packages depending on it (like Ardour and Audacity on suil) need a bump to be rebuilt, should I also post a diff for all them, or you will take care for that?
In D8417#135925, @Jacek wrote:

I think this package can stay as it is, but if next time I would need newer versions of some dependencies, then what steps should I take:

  1. Create a package update requests for each dependency, one for all or can I straight up post the updated diffs?
  2. If other packages depending on it (like Ardour and Audacity on suil) need a bump to be rebuilt, should I also post a diff for all them, or you will take care for that?
  1. Submit patches for updating the dependencies unless there is a MAINTAINERS.md file (if so I'd first try to get in touch on IRC then create a task if needed)
  2. Do the rebuilds locally. If there aren't many, I guess you can submit diffs. If there are many, it's probably easier to use the tag Requires Rebuilds

Do not forget to set the dependencies properly (easiest is to use the depends on keyword in the summary).

JoshStrobl accepted this revision.Mar 13 2020, 3:45 PM

Regarding lilv, suil and iec, if they're too old then you are certainly welcome to provide patches for them. lilv is a revdep of only a few packages, so that shouldn't be problematic, and they have cross-over with the ones for suil too. Rebuilding them using a solbuild local repo and basic testing should be sufficient to validate the updates + stack changes work.

But I'll land this regardless and leave it up to you on whether or not you want to provide updates for those. If you don't feel comfortable modifying those packages and would prefer someone else do it, please submit a package update request (ya know, normal process) and hopefully a Global Maintainer or Core Team can take a look soon :)

This revision is now accepted and ready to land.Mar 13 2020, 3:45 PM
This revision was automatically updated to reflect the committed changes.