Page MenuHomeSolus

Initial commit of fcitx-libpinyin
ClosedPublic

Authored by YakoYakoYokuYoku on Feb 29 2020, 9:22 PM.

Details

Summary

Depends on D8401 and D8402.
The inclusion of fcitx-libpinyin fixes T1298.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Written "你好世界!" ("Hello World!") in Firefox, Hexchat and Krita.

Diff Detail

Repository
R4926 fcitx-libpinyin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Feb 29 2020, 9:22 PM
YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Add the differential dependency

JoshStrobl requested changes to this revision.Mar 3 2020, 12:32 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13

Per your abi_used_libs on D8402, specifying the fcitx dep should not be necessary as it should be a dependency of fcitx-qt5-devel. if it is not, you should rundep the fcitx devel to fcitx-qt5-devel.

20

Doesn't seem to be using SYSCONFDIR or installing anything to it. You sure it is needed?

This revision now requires changes to proceed.Mar 3 2020, 12:32 PM

Removed fcitx-devel dependency and the SYSCONFDIR flag

YakoYakoYokuYoku marked 2 inline comments as done.Mar 3 2020, 3:35 PM
JoshStrobl requested changes to this revision.Mar 7 2020, 8:52 AM
JoshStrobl added inline comments.
package.yml
11

You should be using the description block. Did you not generate this with our package.yml generation script? https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

This revision now requires changes to proceed.Mar 7 2020, 8:52 AM

Fixed the description message

YakoYakoYokuYoku marked an inline comment as done.Mar 7 2020, 7:35 PM
JoshStrobl accepted this revision.Mar 8 2020, 4:22 PM

LGTM, thanks!

This revision is now accepted and ready to land.Mar 8 2020, 4:22 PM
JoshStrobl edited the summary of this revision. (Show Details)Mar 8 2020, 4:27 PM
This revision was automatically updated to reflect the committed changes.