Page MenuHomeSolus

Initial commit of fcitx-qt5
ClosedPublic

Authored by YakoYakoYokuYoku on Feb 29 2020, 9:18 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T1298: Fcitx
Commits
R4925:e1c0fd9a4435: Initial commit of fcitx-qt5
Summary

Depends on D8401.
The inclusion of fcitx-qt5 fixes T1298.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Written "你好世界!" ("Hello World!") and "바나나" ("banana") in Krita.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

YakoYakoYokuYoku requested review of this revision.Feb 29 2020, 9:18 PM
YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Add the differential dependency

JoshStrobl accepted this revision.Mar 3 2020, 12:29 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM!

This revision is now accepted and ready to land.Mar 3 2020, 12:29 PM

Add fcitx-devel as a runtime dependency

hashhsah added a subscriber: hashhsah.EditedMar 3 2020, 4:30 PM

Is fcitx-devel in builddep because of .so libs like /usr/lib/libfcitx-config.so? If that is the case, setting

libsplit   : false

in fcitx may be a better solution.

Is fcitx-devel in builddep because of .so libs like /usr/lib/libfcitx-config.so? If that is the case, setting

libsplit   : false

in fcitx may be a better solution.

I think that /usr/lib/libfcitx-config.so is a symlink to the one at /usr/lib/libfcitx-config.so.4.1, also CMakeLists.txt shows a dependency on the pkgconfig file of fcitx, found in fcitx-devel.

This revision was automatically updated to reflect the committed changes.