Page MenuHomeSolus

Initial commit of fcitx
ClosedPublic

Authored by YakoYakoYokuYoku on Feb 29 2020, 9:16 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T1298: Fcitx
Commits
R4923:0ac650268702: Initial commit of fcitx
Summary

The inclusion of fcitx fixes T1298.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Written "你好世界!" ("Hello World!") in Firefox, Hexchat and Krita.

Diff Detail

Repository
R4923 fcitx
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Feb 29 2020, 9:16 PM
JoshStrobl requested changes to this revision.Mar 3 2020, 12:28 PM
JoshStrobl added a subscriber: JoshStrobl.

Good start, I can certainly tell a lot of work went into this.

Beyond the items I specific marked, I'm seeing a lot of unnecessary builddeps being defined. Please go through your builddeps and double check your reverse dependencies to see if they're already getting pulled in, e.g. cairo, mesalib, some X stuff, etc.

package.yml
39

What does it need networking for?

63

Should be using install not mkdir

64

Alternatively just change the SYSCONFDIR to point the XDG to the right place.

65

Space between flags and file mode bits doesn't need to exist.

This revision now requires changes to proceed.Mar 3 2020, 12:28 PM
YakoYakoYokuYoku updated this revision to Diff 20114.EditedMar 3 2020, 3:22 PM

Fixed the package issues

YakoYakoYokuYoku marked 4 inline comments as done.Mar 3 2020, 3:23 PM
JoshStrobl requested changes to this revision.Mar 7 2020, 8:57 AM

You still need to clean up your build deps.

This revision now requires changes to proceed.Mar 7 2020, 8:57 AM

Cleaned up the build dependencies

Removed pkgconfig(xkbcommon)

JoshStrobl accepted this revision.Mar 8 2020, 4:22 PM

LGTM, thanks!

This revision is now accepted and ready to land.Mar 8 2020, 4:22 PM
This revision was automatically updated to reflect the committed changes.