Page MenuHomeSolus

Initial inclusion of minigalaxy
ClosedPublic

Authored by Hawkeye0021 on Feb 25 2020, 4:16 AM.

Details

Summary

Addresses T8567 package request for minigalaxy GOG client.
This commit is the initial package submission.

Signed-off-by: Donald Thackeray <donaldthackeray@gmail.com>

Test Plan

Package was installed and run. Logging in, out, and back in. Install, launch, and uninstall games. Menus explored and settings toggled successfully.

Diff Detail

Repository
R4929 minigalaxy
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hawkeye0021 created this revision.Feb 25 2020, 4:16 AM
Hawkeye0021 requested review of this revision.Feb 25 2020, 4:16 AM
JoshStrobl requested changes to this revision.Feb 25 2020, 8:35 AM
JoshStrobl added a subscriber: JoshStrobl.

Do not use the AUR or Arch as a basis for packaging in the future. It's blatantly obvious, we have higher standards, and it shows that little effort has been made by the actual maintainer in understanding the software they're packaging in the first place.

In terms of the MAINTAINERS file, it should be .md not .MD

package.yml
13

Not needed, you already have python-setuptools and python is in system.base

16

Part of system.base, not required.

20

Not needed, this is a dep of libwebkit-gtk

21

setup step can be removed given it is empty

26
27

Not necessary

28

Not necessary

29

Not necessary

This revision now requires changes to proceed.Feb 25 2020, 8:35 AM

Do not use the AUR or Arch as a basis for packaging in the future. It's blatantly obvious, we have higher standards, and it shows that little effort has been made by the actual maintainer in understanding the software they're packaging in the first place.
In terms of the MAINTAINERS file, it should be .md not .MD

Well jeeze ok then. It's a process I'm familiar with as a starting place and the only place I could find build and runtime dependencies. At least I bothered to confirm the correct package names in the Solus repositories and that they were indeed the correct packages. Not really a great way to encourage new maintainers and gain more contributors. Sorry for trying to help I guess.

In terms of the MAINTAINERS file, forgot to release the caps key, will fix.

package.yml
13

system.base packages are obviously already on the build machines, right. Will keep in mind.

26

Will inspect macros more closely in the future and determine if additional flags are necessary.

27

Help me understand why these aren't necessary?

Hawkeye0021 updated this revision to Diff 20000.EditedFeb 25 2020, 11:58 PM

MAINTAINERS.MD > MAINTAINERS.md
Removed unecessary build and run dependencies.
Removed unecessary install commands.

Package builds and installs correctly, however the software itself is currently experiencing an issue with downloading games from the GOG server. It appears to be an issue with their API account and may be resolved without need for a further release.

JoshStrobl requested changes to this revision.Mar 3 2020, 12:16 PM

LGTM but if it's having issues downloading games from their server, it significantly limits the usefulness of this software. It'd be like installing Steam but not being able to download and install any of your Steam games. So I'm going to hold off landing this until that issue is resolved, I wouldn't want other users encountering this in the repo and expecting it to function on par with other platform launchers and aggregators (see Lutris and Steam).

Marking as requesting changes, please mark as needs review when it is able to download GOG games reproducibly.

This revision now requires changes to proceed.Mar 3 2020, 12:16 PM

Update to new version with added features and a bug fix for games not downloading.

Jacalz added a subscriber: Jacalz.Mar 11 2020, 5:39 PM
Jacalz added inline comments.
package.yml
7

Looks like the correct license is GPL-3.0-or-later from https://github.com/sharkwouter/minigalaxy/blob/master/LICENSE...

Fixed error where I forgot to add the license again after having to re-create my dev setup.

One minor spelling error, grr.

Hawkeye0021 marked an inline comment as done.Mar 11 2020, 5:49 PM
JoshStrobl accepted this revision.Mar 13 2020, 3:50 PM

LGTM, thanks for the patch and following up with 0.9.3!

This revision is now accepted and ready to land.Mar 13 2020, 3:50 PM
This revision was automatically updated to reflect the committed changes.