Page MenuHomeSolus

construct repo for openpyxl.
ClosedPublic

Authored by hashhsah on Feb 22 2020, 5:01 PM.

Details

Summary

new repo for openpyxl, resolves T8746.

Test Plan

passes built-in test. run first example in documentation (https://openpyxl.readthedocs.io/en/stable/).

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

hashhsah created this revision.Feb 22 2020, 5:01 PM
hashhsah requested review of this revision.Feb 22 2020, 5:01 PM
kyrios123 requested changes to this revision.Feb 22 2020, 6:06 PM
kyrios123 added a subscriber: kyrios123.

Please remove the python2 bits from your package.

Thanks πŸ˜ƒ

This revision now requires changes to proceed.Feb 22 2020, 6:06 PM

Does removing python2 bits mean removing %python_setup while keeping %python3_setup only?

openpyxl happens to be a python3-only package, and didn't have python2 at all.

hashhsah updated this revision to Diff 19968.Feb 24 2020, 3:50 PM

rebuilt, after making jdcal/et_xmlfile python3 only.
as expected, nothing changed in this package.

@kyrios123 would you take a look at this again? thx

kyrios123 requested changes to this revision.Mar 4 2020, 12:24 PM
kyrios123 added inline comments.
package.yml
14

This is for python2 only so it should be removed.

This revision now requires changes to proceed.Mar 4 2020, 12:24 PM
hashhsah updated this revision to Diff 20132.Mar 4 2020, 2:06 PM

removing python-setuptools, the "python2 bit"

@kyrios123 hopefully this time i got what you meant by removing python2. please take a look. thx.

DataDrake requested changes to this revision.Apr 15 2020, 4:37 AM
DataDrake added a subscriber: DataDrake.

Almost there :)

package.yml
13

Deps should be alphabetical with pkgconfigs first, please.

This revision now requires changes to proceed.Apr 15 2020, 4:37 AM
hashhsah updated this revision to Diff 20852.Apr 15 2020, 3:40 PM

re-order dependencies alphabetically.

DataDrake accepted this revision.Apr 15 2020, 3:56 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 15 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.