Page MenuHomeSolus
Differential D8330

construct repo for openpyxl.
ClosedPublic
Actions

Authored by hashhsah on Feb 22 2020, 5:01 PM.
Tags
None
Referenced Files
F11006498: D8330.diff
Tue, Aug 1, 3:38 PM
F10878658: D8330.id20132.diff
Jun 21 2023, 12:06 PM
F10874781: D8330.id19968.diff
Jun 20 2023, 2:09 AM
F10874779: D8330.id20852.diff
Jun 20 2023, 2:08 AM
F10843676: D8330.id.diff
Jun 10 2023, 6:52 PM
F10828066: D8330.id19968.diff
Jun 4 2023, 8:20 AM
F10780824: D8330.id.diff
May 25 2023, 4:09 AM
F10762501: D8330.id19926.diff
May 18 2023, 6:14 PM
View All 14 Files
Subscribers
DataDrake
kyrios123

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8746: OpenPyXL and its dependency
Commits
R4968:24dcd6ed73e3: construct repo for openpyxl.
Summary

new repo for openpyxl, resolves T8746.

Test Plan

passes built-in test. run first example in documentation (https://openpyxl.readthedocs.io/en/stable/).

Diff Detail

Repository
R4968 python-openpyxl
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hashhsah created this revision.Feb 22 2020, 5:01 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 22 2020, 5:01 PM
hashhsah requested review of this revision.Feb 22 2020, 5:01 PM
hashhsah added child revisions: D8329: construct repo for et_xmlfile., D8328: construct repo for jdcal..Feb 22 2020, 5:02 PM
kyrios123 requested changes to this revision.Feb 22 2020, 6:06 PM
kyrios123 added a subscriber: kyrios123.

Please remove the python2 bits from your package.

Thanks ?

This revision now requires changes to proceed.Feb 22 2020, 6:06 PM
hashhsah added a comment.Feb 22 2020, 11:04 PM

Does removing python2 bits mean removing %python_setup while keeping %python3_setup only?

openpyxl happens to be a python3-only package, and didn't have python2 at all.

hashhsah updated this revision to Diff 19968.Feb 24 2020, 3:50 PM

rebuilt, after making jdcal/et_xmlfile python3 only.
as expected, nothing changed in this package.

hashhsah added a comment.Mar 4 2020, 7:29 AM

@kyrios123 would you take a look at this again? thx

kyrios123 requested changes to this revision.Mar 4 2020, 12:24 PM
kyrios123 added inline comments.
package.yml
15

This is for python2 only so it should be removed.

This revision now requires changes to proceed.Mar 4 2020, 12:24 PM
hashhsah updated this revision to Diff 20132.Mar 4 2020, 2:06 PM

removing python-setuptools, the "python2 bit"

hashhsah added a comment.Mar 5 2020, 5:34 PM

@kyrios123 hopefully this time i got what you meant by removing python2. please take a look. thx.

DataDrake requested changes to this revision.Apr 15 2020, 4:37 AM
DataDrake added a subscriber: DataDrake.

Almost there :)

package.yml
13

Deps should be alphabetical with pkgconfigs first, please.

This revision now requires changes to proceed.Apr 15 2020, 4:37 AM
hashhsah updated this revision to Diff 20852.Apr 15 2020, 3:40 PM

re-order dependencies alphabetically.

DataDrake accepted this revision.Apr 15 2020, 3:56 PM

LGTM. Thanks!

DataDrake removed child revisions: D8328: construct repo for jdcal., D8329: construct repo for et_xmlfile..Apr 15 2020, 3:57 PM
DataDrake added parent revisions: D8329: construct repo for et_xmlfile., D8328: construct repo for jdcal..
DataDrake removed a reviewer: kyrios123.
This revision is now accepted and ready to land.Apr 15 2020, 3:58 PM
Closed by commit R4968:24dcd6ed73e3: construct repo for openpyxl. (authored by hash <hashhsah@gmail.com>, committed by DataDrake). · Explain WhyMay 13 2020, 5:13 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4968:24dcd6ed73e3: construct repo for openpyxl..

Revision Contents
Changeset List

PathSize
1 line
27 lines
411 lines

Diff 21243

View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.