Page MenuHomeSolus

construct repo for et_xmlfile.
ClosedPublic

Authored by hashhsah on Feb 22 2020, 4:58 PM.

Details

Summary

add et_xmlfile as dependence of openpyxl.

Test Plan

pass built-in test. then test through openpyxl.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

hashhsah created this revision.Feb 22 2020, 4:58 PM
hashhsah requested review of this revision.Feb 22 2020, 4:58 PM
kyrios123 requested changes to this revision.Feb 22 2020, 6:05 PM
kyrios123 added a subscriber: kyrios123.

Please remove the python2 bits from your package.
Also don't use 80 cols for the description.

Thanks πŸ˜ƒ

This revision now requires changes to proceed.Feb 22 2020, 6:05 PM
hashhsah updated this revision to Diff 19967.Feb 24 2020, 2:40 PM

removed python2 support. re-format description.

kyrios123 requested changes to this revision.Mar 4 2020, 12:23 PM
kyrios123 added inline comments.
package.yml
14

This is for python2 only so it should be removed.

This revision now requires changes to proceed.Mar 4 2020, 12:23 PM
hashhsah updated this revision to Diff 20130.Mar 4 2020, 1:41 PM

removed python-setuptools, the "python2 bit".

DataDrake requested changes to this revision.Apr 15 2020, 4:39 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
13

Should be alphabetical

This revision now requires changes to proceed.Apr 15 2020, 4:39 AM
hashhsah updated this revision to Diff 20851.Apr 15 2020, 3:16 PM

re-order dependencies alphabetically

DataDrake accepted this revision.Apr 15 2020, 3:56 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 15 2020, 3:56 PM
This revision was automatically updated to reflect the committed changes.