Page MenuHomeSolus
Differential D8329

construct repo for et_xmlfile.
ClosedPublic
Actions

Authored by hashhsah on Feb 22 2020, 4:58 PM.
Tags
None
Referenced Files
F11006500: D8329.diff
Tue, Aug 1, 3:38 PM
F10828285: D8329.id20130.diff
Jun 4 2023, 8:58 AM
F10822887: D8329.diff
Jun 3 2023, 12:12 AM
F10762465: D8329.id19967.diff
May 18 2023, 5:55 PM
F10762453: D8329.id21241.diff
May 18 2023, 5:45 PM
F10762430: D8329.id20851.diff
May 18 2023, 5:35 PM
F10762410: D8329.id19925.diff
May 18 2023, 5:24 PM
F10735467: D8329.diff
May 12 2023, 1:59 PM
View All 9 Files
Subscribers
DataDrake
kyrios123

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R4967:cfd85efb7f93: construct repo for et_xmlfile.
Summary

add et_xmlfile as dependence of openpyxl.

Test Plan

pass built-in test. then test through openpyxl.

Diff Detail

Repository
R4967 python-et_xmlfile
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hashhsah created this revision.Feb 22 2020, 4:58 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 22 2020, 4:58 PM
hashhsah requested review of this revision.Feb 22 2020, 4:58 PM
hashhsah added a parent revision: D8330: construct repo for openpyxl..Feb 22 2020, 5:02 PM
kyrios123 requested changes to this revision.Feb 22 2020, 6:05 PM
kyrios123 added a subscriber: kyrios123.

Please remove the python2 bits from your package.
Also don't use 80 cols for the description.

Thanks ?

This revision now requires changes to proceed.Feb 22 2020, 6:05 PM
hashhsah updated this revision to Diff 19967.Feb 24 2020, 2:40 PM

removed python2 support. re-format description.

kyrios123 requested changes to this revision.Mar 4 2020, 12:23 PM
kyrios123 added inline comments.
package.yml
15

This is for python2 only so it should be removed.

This revision now requires changes to proceed.Mar 4 2020, 12:23 PM
hashhsah updated this revision to Diff 20130.Mar 4 2020, 1:41 PM

removed python-setuptools, the "python2 bit".

DataDrake requested changes to this revision.Apr 15 2020, 4:39 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
13

Should be alphabetical

This revision now requires changes to proceed.Apr 15 2020, 4:39 AM
hashhsah updated this revision to Diff 20851.Apr 15 2020, 3:16 PM

re-order dependencies alphabetically

DataDrake accepted this revision.Apr 15 2020, 3:56 PM

LGTM. Thanks!

DataDrake removed a reviewer: kyrios123.Apr 15 2020, 3:56 PM
This revision is now accepted and ready to land.Apr 15 2020, 3:56 PM
DataDrake removed a parent revision: D8330: construct repo for openpyxl..Apr 15 2020, 3:57 PM
DataDrake added a child revision: D8330: construct repo for openpyxl..
Closed by commit R4967:cfd85efb7f93: construct repo for et_xmlfile. (authored by hash <hashhsah@gmail.com>, committed by DataDrake). · Explain WhyMay 13 2020, 5:08 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4967:cfd85efb7f93: construct repo for et_xmlfile..

Revision Contents
Changeset List

PathSize
1 line
21 lines
50 lines

Diff 21241

View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.