Page MenuHomeSolus

construct repo for jdcal.
ClosedPublic

Authored by hashhsah on Feb 22 2020, 4:56 PM.

Details

Summary

new package jdcal as dependence of openpyxl.

Test Plan

passes built-in tests. test through openpyxl.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

hashhsah created this revision.Feb 22 2020, 4:56 PM
hashhsah requested review of this revision.Feb 22 2020, 4:56 PM

Please remove the python2 bits from your package.
Also don't use 80 cols for the description.

Thanks 😃

kyrios123 requested changes to this revision.Feb 22 2020, 6:04 PM
This revision now requires changes to proceed.Feb 22 2020, 6:04 PM
hashhsah updated this revision to Diff 19966.Feb 24 2020, 2:34 PM

removing python2 support. re-format description.

kyrios123 requested changes to this revision.Mar 4 2020, 12:22 PM
kyrios123 added inline comments.
package.yml
15

This is for python2 only so it should be removed

This revision now requires changes to proceed.Mar 4 2020, 12:22 PM
hashhsah updated this revision to Diff 20131.Mar 4 2020, 1:50 PM

removing python-setup, the "python2 bits".

DataDrake accepted this revision.Apr 15 2020, 4:40 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 15 2020, 3:55 PM
This revision was automatically updated to reflect the committed changes.