Page MenuHomeSolus
Differential D8328

construct repo for jdcal.
ClosedPublic
Actions

Authored by hashhsah on Feb 22 2020, 4:56 PM.
Tags
None
Referenced Files
F11015963: D8328.id19924.diff
Sat, Aug 5, 3:35 PM
F11006507: D8328.diff
Tue, Aug 1, 3:41 PM
F10979275: D8328.id21240.diff
Sat, Jul 22, 11:09 PM
F10974896: D8328.id19966.diff
Sat, Jul 22, 2:47 AM
F10875924: D8328.id20131.diff
Jun 20 2023, 8:12 AM
F10830753: D8328.id20131.diff
Jun 5 2023, 1:22 AM
F10816952: D8328.diff
Jun 1 2023, 4:43 AM
F10762498: D8328.id19924.diff
May 18 2023, 6:13 PM
View All 15 Files
Subscribers
DataDrake
kyrios123

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R4966:06d2e48df9fe: construct repo for jdcal.
Summary

new package jdcal as dependence of openpyxl.

Test Plan

passes built-in tests. test through openpyxl.

Diff Detail

Repository
R4966 python-jdcal
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hashhsah created this revision.Feb 22 2020, 4:56 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 22 2020, 4:56 PM
hashhsah requested review of this revision.Feb 22 2020, 4:56 PM
hashhsah added a parent revision: D8330: construct repo for openpyxl..Feb 22 2020, 5:02 PM
kyrios123 added a subscriber: kyrios123.Feb 22 2020, 6:04 PM

Please remove the python2 bits from your package.
Also don't use 80 cols for the description.

Thanks ?

kyrios123 requested changes to this revision.Feb 22 2020, 6:04 PM
This revision now requires changes to proceed.Feb 22 2020, 6:04 PM
hashhsah updated this revision to Diff 19966.Feb 24 2020, 2:34 PM

removing python2 support. re-format description.

kyrios123 requested changes to this revision.Mar 4 2020, 12:22 PM
kyrios123 added inline comments.
package.yml
15

This is for python2 only so it should be removed

This revision now requires changes to proceed.Mar 4 2020, 12:22 PM
hashhsah updated this revision to Diff 20131.Mar 4 2020, 1:50 PM

removing python-setup, the "python2 bits".

DataDrake accepted this revision.Apr 15 2020, 4:40 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

DataDrake removed a reviewer: kyrios123.Apr 15 2020, 3:55 PM
This revision is now accepted and ready to land.Apr 15 2020, 3:55 PM
DataDrake removed a parent revision: D8330: construct repo for openpyxl..Apr 15 2020, 3:57 PM
DataDrake added a child revision: D8330: construct repo for openpyxl..
Closed by commit R4966:06d2e48df9fe: construct repo for jdcal. (authored by hash <hashhsah@gmail.com>, committed by DataDrake). · Explain WhyMay 13 2020, 5:06 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4966:06d2e48df9fe: construct repo for jdcal..

Revision Contents
Changeset List

PathSize
1 line
20 lines
40 lines

Diff 21240

View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.