Page MenuHomeSolus
Differential D8321

Update sassc to 3.6.1
ClosedPublic
Actions

Authored by algent on Feb 20 2020, 8:07 PM.
Tags
None
Referenced Files
F10988645: D8321.id19918.diff
Mon, Jul 24, 11:49 AM
F10887562: D8321.id19918.diff
Jun 26 2023, 2:02 PM
F10887477: D8321.id19917.diff
Jun 26 2023, 12:56 PM
F10887436: D8321.id19896.diff
Jun 26 2023, 12:16 PM
F10886242: D8321.id19953.diff
Jun 25 2023, 8:08 PM
F10883734: D8321.diff
Jun 24 2023, 2:11 PM
F10803706: D8321.id.diff
May 29 2023, 1:05 PM
F10784764: D8321.id19953.diff
May 26 2023, 1:55 AM
View All 10 Files
Subscribers
DataDrake
JoshStrobl

Details

Reviewers
JoshStrobl
DataDrake
Group Reviewers
Triage Team
Commits
R2847:214a5f8ba429: Update sassc to 3.6.1
Summary

Changelog:

See libsass changelogs:

Depends on D8320

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Successfully rebuild against newer sassc:

  • adapta-gtk-theme
  • arc-gtk-theme
  • breeze-gtk-theme
  • budgie-desktop
  • gnome-shell
  • plata-theme
  • something-for-reddit
  • yaru-theme
  • zuki-themes

Diff Detail

Repository
R2847 sassc
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

algent created this revision.Feb 20 2020, 8:07 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 20 2020, 8:07 PM
algent requested review of this revision.Feb 20 2020, 8:07 PM
algent added a child revision: D8322: Update zuki-themes to 3.34.2.Feb 20 2020, 8:14 PM
JoshStrobl requested changes to this revision.Feb 21 2020, 8:46 AM
JoshStrobl added a subscriber: JoshStrobl.

So have you validated that the internal theme in budgie-desktop correctly compiles with newer sassc? Need validation of that in your test plan.

This revision now requires changes to proceed.Feb 21 2020, 8:46 AM
algent updated this revision to Diff 19917.Feb 21 2020, 6:52 PM

Update against libsass-3.6.1

algent updated this revision to Diff 19918.Feb 21 2020, 6:56 PM
algent edited the summary of this revision. (Show Details)
algent edited the test plan for this revision. (Show Details)

Update sassc using proper version of libsass

algent added a child revision: D8324: Fix and safe rebuild against sassc.Feb 21 2020, 7:32 PM
DataDrake accepted this revision.Feb 23 2020, 1:46 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:54 PM
Closed by commit R2847:214a5f8ba429: Update sassc to 3.6.1 (authored by algent, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R2847:214a5f8ba429: Update sassc to 3.6.1.

Revision Contents
Changeset List

PathSize
10 lines
21 lines

Diff 19917

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.