Page MenuHomeSolus

Add missing paths to fix snaps when using zsh
ClosedPublic

Authored by Harvey on Feb 20 2020, 10:34 AM.

Details

Summary

Packaging fix addressing snap packages being broken when using both zsh and sddm
Resolves T8750

Test Plan
  • Login
  • Run some commands using bash and zsh
  • Install, launch, remove snap packages using bash and zsh

Diff Detail

Repository
R3469 sddm
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Harvey created this revision.Feb 20 2020, 10:34 AM
Harvey requested review of this revision.Feb 20 2020, 10:34 AM
Girtablulu accepted this revision.Feb 20 2020, 10:48 AM
Girtablulu added a subscriber: Girtablulu.

LGTM, thx

This revision is now accepted and ready to land.Feb 20 2020, 10:48 AM
Harvey planned changes to this revision.Feb 23 2020, 2:21 AM
Girtablulu added inline comments.Feb 24 2020, 5:04 PM
pspec_x86_64.xml
23

could you remove that empty folder? So I dont have to after this updates gets in :)

Harvey updated this revision to Diff 19981.Feb 25 2020, 2:19 AM

Add location of stateless zsh startup/shudown files

This revision is now accepted and ready to land.Feb 25 2020, 2:19 AM

As discussed in T8750 || isn't working and I don't think its needed. I have made all zsh startup/shudown files stateless which should mean it never needs to look elsewhere.

Harvey requested review of this revision.Feb 25 2020, 2:25 AM
Girtablulu accepted this revision.Feb 28 2020, 2:57 PM

Still looks good to me, but as said wanna have the okay from core reg D8314

This revision is now accepted and ready to land.Feb 28 2020, 2:57 PM
JoshStrobl accepted this revision.Mar 8 2020, 4:42 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM πŸ‘