Differential D8315

Add missing paths to fix snaps when using zsh
ClosedPublic
Actions

Authored by Harvey on Feb 20 2020, 10:34 AM.

Tags

None

Referenced Files

	F11015242: D8315.diff
	Sat, Aug 5, 10:23 AM

	F11002167: D8315.diff
	Sun, Jul 30, 11:56 PM

	F10903755: D8315.id19890.diff
	Jul 5 2023, 5:24 PM

	F10873373: D8315.id19890.diff
	Jun 19 2023, 12:09 PM

	F10852212: D8315.id19890.diff
	Jun 12 2023, 9:45 PM

	F10851171: D8315.id20230.diff
	Jun 12 2023, 10:00 AM

	F10851169: D8315.id19981.diff
	Jun 12 2023, 9:59 AM

	F10851168: D8315.id19890.diff
	Jun 12 2023, 9:59 AM

View All 19 Files

Subscribers

Details

Reviewers

Girtablulu
JoshStrobl

Group Reviewers

Maniphest Tasks

T8750: snaps appear to be broken when using zsh

Commits

R3469:6e75da6c615d: Add missing paths to fix snaps when using zsh

Summary

Packaging fix addressing snap packages being broken when using both zsh and sddm
Resolves T8750

Test Plan

Login
Run some commands using bash and zsh
Install, launch, remove snap packages using bash and zsh

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Harvey created this revision.Feb 20 2020, 10:34 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 20 2020, 10:34 AM

Harvey requested review of this revision.Feb 20 2020, 10:34 AM

LGTM, thx

This revision is now accepted and ready to land.Feb 20 2020, 10:48 AM

Harvey planned changes to this revision.Feb 23 2020, 2:21 AM

Harvey mentioned this in D8314: add zprofile to fix snap packages when using sddm.Feb 23 2020, 2:22 AM

Girtablulu added inline comments.Feb 24 2020, 5:04 PM

pspec_x86_64.xml
22–23	could you remove that empty folder? So I dont have to after this updates gets in :)

Add location of stateless zsh startup/shudown files

This revision is now accepted and ready to land.Feb 25 2020, 2:19 AM

As discussed in T8750 || isn't working and I don't think its needed. I have made all zsh startup/shudown files stateless which should mean it never needs to look elsewhere.

Harvey requested review of this revision.Feb 25 2020, 2:25 AM

Still looks good to me, but as said wanna have the okay from core reg D8314

This revision is now accepted and ready to land.Feb 28 2020, 2:57 PM

LGTM 👍

Closed by commit R3469:6e75da6c615d: Add missing paths to fix snaps when using zsh (authored by Harvey, committed by Girtablulu). · Explain WhyMar 8 2020, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R3469:6e75da6c615d: Add missing paths to fix snaps when using zsh.

Girtablulu mentioned this in R3329:c609aba3edf7: add zprofile to fix snap packages when using sddm.

Revision Contents
Changeset List

Path

Size

files/

0002-Fix-zsh-for-solus.patch

14 lines

4 lines

pspec_x86_64.xml

13 lines

Diff 20230

files/0002-Fix-zsh-for-solus.patch

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...