Page MenuHomeSolus
Differential D8295

Update FlashROM to v1.2
ClosedPublic
Actions

Authored by moriel5 on Feb 19 2020, 9:47 AM.
Tags
None
Referenced Files
F11038383: D8295.id19855.diff
Wed, Aug 9, 10:35 PM
F11038382: D8295.id.diff
Wed, Aug 9, 10:35 PM
F11038381: D8295.id19858.diff
Wed, Aug 9, 10:34 PM
F11038380: D8295.id20150.diff
Wed, Aug 9, 10:34 PM
F11038379: D8295.id20769.diff
Wed, Aug 9, 10:34 PM
F11027450: D8295.diff
Wed, Aug 9, 4:22 AM
F10908639: D8295.id20769.diff
Jul 7 2023, 12:57 AM
F10878418: D8295.diff
Jun 21 2023, 8:56 AM
View All 25 Files
Subscribers
DataDrake

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R4603:db1b536ed0b6: Update FlashROM to v1.2
Summary

Changelog taken from FlashROM mailinglist (here), since I am subscribed to it, and the changelog has not been put up on the wiki yet.

Changes since 1.1

  • Meson support (hello fwupd!)
  • Layout improvements/fixes and many, many code cleanups.
  • 5 new chips + 3 new variants
  • 3 new programmers + support for more Intel PCHs
  • Reduced dependency on libusb0
  • Syntax: Added --flash-name and --flash-size arguments to print

information about the flash chip

Test Plan

Unfortunately, I cannot test this at this time, I'll be very grateful if someone can test this for me.

Diff Detail

Repository
R4603 flashrom
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

moriel5 created this revision.Feb 19 2020, 9:47 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 19 2020, 9:47 AM
moriel5 requested review of this revision.Feb 19 2020, 9:47 AM
DataDrake requested changes to this revision.Feb 19 2020, 1:33 PM
DataDrake added a subscriber: DataDrake.

If they support Meson now, I'd rather use that than Make if you wouldn't mind trying it.

This revision now requires changes to proceed.Feb 19 2020, 1:33 PM
moriel5 added a comment.Feb 19 2020, 1:57 PM

Sure thing, I'd prefer that as well.

moriel5 edited the summary of this revision. (Show Details)Feb 19 2020, 2:09 PM
moriel5 edited the summary of this revision. (Show Details)
moriel5 updated this revision to Diff 19858.Feb 19 2020, 2:17 PM

Updating D8295: Update FlashROM to v1.2

Changelog taken from FlashROM mailinglist (here), since I am subscribed to it, and the changelog has not been put up on the wiki yet.

Changes since 1.1

  • Meson support (hello fwupd!)
  • Layout improvements/fixes and many, many code cleanups.
  • 5 new chips + 3 new variants
  • 3 new programmers + support for more Intel PCHs
  • Reduced dependency on libusb0
  • Syntax: Added --flash-name and --flash-size arguments to print

information about the flash chip

moriel5 added a comment.Feb 19 2020, 2:18 PM

Updated.
Now development headers are also created.

moriel5 added a comment.Feb 19 2020, 2:20 PM

That's odd, abi_symbols wasn't added.

DataDrake added a comment.Feb 23 2020, 1:17 PM
In D8295#133050, @moriel5 wrote:

That's odd, abi_symbols wasn't added.

It did when I built it locally just now. Did you forget to git add?

moriel5 added a comment.Feb 24 2020, 9:16 AM
In D8295#133667, @DataDrake wrote:
In D8295#133050, @moriel5 wrote:

That's odd, abi_symbols wasn't added.

It did when I built it locally just now. Did you forget to git add?

I didn't know I had to, as I am not proficient with git yet.
Is git add --update the correct command?

moriel5 updated this revision to Diff 20150.Mar 5 2020, 3:43 PM

Added abi_symbols

DataDrake accepted this revision.Apr 13 2020, 2:33 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 13 2020, 2:33 AM
Closed by commit R4603:db1b536ed0b6: Update FlashROM to v1.2 (authored by moriel5, committed by DataDrake). · Explain WhyApr 13 2020, 2:34 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4603:db1b536ed0b6: Update FlashROM to v1.2.

Revision Contents
Changeset List

PathSize
24 lines
3 lines
13 lines
24 lines

Diff 20150

View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.