Page MenuHomeSolus

Update FlashROM to v1.2
ClosedPublic

Authored by moriel5 on Feb 19 2020, 9:47 AM.

Details

Summary

Changelog taken from FlashROM mailinglist (here), since I am subscribed to it, and the changelog has not been put up on the wiki yet.

Changes since 1.1

  • Meson support (hello fwupd!)
  • Layout improvements/fixes and many, many code cleanups.
  • 5 new chips + 3 new variants
  • 3 new programmers + support for more Intel PCHs
  • Reduced dependency on libusb0
  • Syntax: Added --flash-name and --flash-size arguments to print

information about the flash chip

Test Plan

Unfortunately, I cannot test this at this time, I'll be very grateful if someone can test this for me.

Diff Detail

Repository
R4603 flashrom
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

moriel5 created this revision.Feb 19 2020, 9:47 AM
moriel5 requested review of this revision.Feb 19 2020, 9:47 AM
DataDrake requested changes to this revision.Feb 19 2020, 1:33 PM
DataDrake added a subscriber: DataDrake.

If they support Meson now, I'd rather use that than Make if you wouldn't mind trying it.

This revision now requires changes to proceed.Feb 19 2020, 1:33 PM

Sure thing, I'd prefer that as well.

moriel5 edited the summary of this revision. (Show Details)Feb 19 2020, 2:09 PM
moriel5 edited the summary of this revision. (Show Details)
moriel5 updated this revision to Diff 19858.Feb 19 2020, 2:17 PM

Updating D8295: Update FlashROM to v1.2

Changelog taken from FlashROM mailinglist (here), since I am subscribed to it, and the changelog has not been put up on the wiki yet.

Changes since 1.1

  • Meson support (hello fwupd!)
  • Layout improvements/fixes and many, many code cleanups.
  • 5 new chips + 3 new variants
  • 3 new programmers + support for more Intel PCHs
  • Reduced dependency on libusb0
  • Syntax: Added --flash-name and --flash-size arguments to print

information about the flash chip

Updated.
Now development headers are also created.

That's odd, abi_symbols wasn't added.

That's odd, abi_symbols wasn't added.

It did when I built it locally just now. Did you forget to git add?

That's odd, abi_symbols wasn't added.

It did when I built it locally just now. Did you forget to git add?

I didn't know I had to, as I am not proficient with git yet.
Is git add --update the correct command?

moriel5 updated this revision to Diff 20150.Mar 5 2020, 3:43 PM

Added abi_symbols

DataDrake accepted this revision.Apr 13 2020, 2:33 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 13 2020, 2:33 AM
This revision was automatically updated to reflect the committed changes.