Page MenuHomeSolus
Differential D8292

Fix github issue 1038 for mypaint
ClosedPublic
Actions

Authored by xulongwu4 on Feb 19 2020, 2:07 AM.
Tags
None
Referenced Files
F11066984: D8292.diff
Fri, Aug 11, 7:10 PM
F11062502: D8292.id19901.diff
Fri, Aug 11, 12:42 PM
F11040234: D8292.diff
Thu, Aug 10, 1:57 AM
F10890925: D8292.id19901.diff
Jun 28 2023, 6:52 PM
F10889424: D8292.id19824.diff
Jun 27 2023, 10:30 PM
F10889082: D8292.id20796.diff
Jun 27 2023, 1:17 PM
F10885073: D8292.diff
Jun 25 2023, 7:02 AM
F10822010: D8292.id19824.diff
Jun 2 2023, 4:47 PM
View All 9 Files
Subscribers
DataDrake

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R2127:5416f1014118: Revert "Update mypaint to 2.0.1"
R2127:4da00d63d052: Fix github issue 1038 for mypaint
Summary

Add a patch to fix github issue 1038 and rebuild against python-protobuf 3.11.3.

Test Plan

Launched it successfully and used various tools to draw lines. Also tested the feather tool and made sure that the bug in github issue 1038 didn't happen.

Diff Detail

Repository
R2127 mypaint
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

xulongwu4 created this revision.Feb 19 2020, 2:07 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 19 2020, 2:07 AM
xulongwu4 requested review of this revision.Feb 19 2020, 2:07 AM
xulongwu4 added a parent revision: D8290: Update python-protobuf to 3.11.3.Feb 19 2020, 2:08 AM
xulongwu4 edited the summary of this revision. (Show Details)
xulongwu4 updated this revision to Diff 19901.Feb 21 2020, 2:50 AM

Rebase on master and add a patch to fix github issue 1038.

xulongwu4 retitled this revision from Fix swig 4 build failure to Fix github issue 1038 for mypaint.Feb 21 2020, 2:53 AM
xulongwu4 edited the summary of this revision. (Show Details)
xulongwu4 edited the test plan for this revision. (Show Details)
DataDrake accepted this revision.Apr 12 2020, 8:30 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 12 2020, 8:30 PM
Closed by commit R2127:4da00d63d052: Fix github issue 1038 for mypaint (authored by xulongwu4, committed by Girtablulu). · Explain WhyApr 13 2020, 1:07 PM
This revision was automatically updated to reflect the committed changes.
Girtablulu added a commit: R2127:4da00d63d052: Fix github issue 1038 for mypaint.
Girtablulu added a commit: R2127:5416f1014118: Revert "Update mypaint to 2.0.1".Dec 28 2020, 5:18 PM

Revision Contents
Changeset List

PathSize
files/
15 lines
5 lines
12 lines

Diff 19901

View Options

files/inking-tool.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.