Page MenuHomeSolus

Initial inclusion of cgdb
ClosedPublic

Authored by tomocafe on Feb 16 2020, 11:26 PM.
Tags
None
Referenced Files
F10889811: D8276.id19885.diff
Jun 28 2023, 4:13 AM
F10889622: D8276.id19801.diff
Jun 28 2023, 1:18 AM
F10888607: D8276.id20359.diff
Jun 27 2023, 5:16 AM
F10884040: D8276.diff
Jun 24 2023, 6:11 PM
F10865184: D8276.id19885.diff
Jun 17 2023, 10:34 AM
F10739191: D8276.id19885.diff
May 13 2023, 5:27 PM
F10734991: D8276.diff
May 12 2023, 10:04 AM
F10727551: D8276.diff
May 9 2023, 10:27 PM
Subscribers

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8505: cgdb
Commits
R4933:b448592da3ac: Initial inclusion of cgdb
Summary

Initial inclusion of cgdb. Fixes T8505.

Test Plan

Use it to debug a C++ program

Diff Detail

Repository
R4933 cgdb
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.

Please include the following contents as a MAINTAINERS.md file:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- Evan Wegley
  - IRC: tomocafe
  - Email: tomocafe@pm.me
package.yml
13

You can just use our %autogen macro instead of autogen + configure

This revision now requires changes to proceed.Feb 19 2020, 7:55 AM

Ready for review.

package.yml
13

So this is a weird autogen script it seems: https://github.com/cgdb/cgdb/blob/v0.7.1/autogen.sh

It won't actually work unless it has no arguments, so the standard macro doesn't work as it prevents configure.ac from being created. Also you have to pass in the actual version string as an environment variable, otherwise it falls back to a date string. I fixed that anyway.

Either we can keep it this way, or I will need to patch the autogen.sh script. Up to you on how we want to proceed.

Thanks!

LGTM, thanks!

package.yml
13

Eh. Let's just go with this then.

This revision is now accepted and ready to land.Mar 19 2020, 5:08 PM
This revision was automatically updated to reflect the committed changes.