Page MenuHomeSolus

GtkStressTesting
Needs RevisionPublic

Authored by jwinnie on Fri, Feb 14, 2:54 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Initial build of T8640. Builds correctly, but doesn't work yet because of missing Python dependencies.

Test Plan

n/a

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

jwinnie created this revision.Fri, Feb 14, 2:54 AM
jwinnie requested review of this revision.Fri, Feb 14, 2:54 AM
jwinnie updated this revision to Diff 19754.Fri, Feb 14, 3:14 AM

Remove extraneous dependencies

JoshStrobl requested changes to this revision.Fri, Feb 14, 3:30 AM
JoshStrobl added a subscriber: JoshStrobl.

That's not how you remove extra unnecessary deps and "n/a" isn't a valid test plan. It is very much applicable.

This revision now requires changes to proceed.Fri, Feb 14, 3:30 AM

Those packages are commented out right now because they don't exist in the repos yet. Currently I cannot test it because it crashes on start due to missing dependencies. Before this package is submitted those dependencies need to be packaged into the repos.

Those packages are commented out right now because they don't exist in the repos yet.

That's why we have solbuild local repositories: https://getsol.us/articles/packaging/local-repository/en/

By the way PyYAML is in the repository

algent added a subscriber: algent.Fri, Feb 14, 9:52 AM

Two of the rundeps are already in repository:
python-xdg should be pyxdg
python-yaml should be pyyaml

jwinnie added a comment.EditedFri, Feb 14, 5:08 PM

@algent Is there any particular reason for this naming scheme? It seems rather inconsistent.

This kind of discussion is better to be done in our irc channel #Solus-Dev.

About pyxdg this is how its developer named it. The same with pyyaml.
You can see in repology.org how other distros have named these packages: pyyaml and pyxdg.

Also GtkStressTesting is named gst from its developer. Other distros followed also same naming, just gst.
I think it is better for solus too, to use name 'gst' instead of gtkstresstesting.

jwinnie updated this revision to Diff 19765.Sat, Feb 15, 4:57 AM

Fixed issues mentioned by @algent

jwinnie updated this revision to Diff 19766.Sat, Feb 15, 5:01 AM

Update pspec

JoshStrobl requested changes to this revision.Sat, Feb 15, 11:35 AM

Changes didn't address my comments. Have further review items as well.

package.yml
7
pspec_x86_64.xml
23

This is going to conflict with any usage of the oh-my-zsh git plugin. Their meson.build for the gst binary should be patched to have binary be outputted as something like gtk-stress-testing.

Their service and desktop files will also likely need to be patched for the changed binary name: https://gitlab.com/leinardi/gst/-/tree/release/data

This revision now requires changes to proceed.Sat, Feb 15, 11:35 AM

@JoshStrobl So should the packagename and everything be changed too, or just the binary?

jwinnie updated this revision to Diff 19812.Mon, Feb 17, 8:58 PM

Fix license

YakoYakoYokuYoku added inline comments.
package.yml
1

gst is an alias for gstreamer, name should be gtk-stress-testing

JoshStrobl requested changes to this revision.Tue, Feb 18, 2:15 PM

Name, binary, data (desktop files, service files, etc.). The site-packages could probably stay the same.

This revision now requires changes to proceed.Tue, Feb 18, 2:15 PM

Also @YakoYakoYokuYoku, please leave the reviewing the Core Team and Global Maintainers. Thanks.

Should the name be GtkStressTesting or gtk-stress-testing?

Don't use capital letters in package name please.