Page MenuHomeSolus

GtkStressTesting
Needs RevisionPublic

Authored by jwinnie on Feb 14 2020, 2:54 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

T8640: GtkStressTesting, a GTK application to monitor and test various hardware components like CPU and RAM

Currently blocking on the acceptance of D8410, D8409 and D8408, which are required runtime dependencies.

Test Plan

Launches without errors. Correctly displays information about CPU and RAM. Policykit authentication dialog works fine. Ran benchmark and 30 second stress test, everything worked fine.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

jwinnie created this revision.Feb 14 2020, 2:54 AM
jwinnie requested review of this revision.Feb 14 2020, 2:54 AM
jwinnie updated this revision to Diff 19754.Feb 14 2020, 3:14 AM

Remove extraneous dependencies

JoshStrobl requested changes to this revision.Feb 14 2020, 3:30 AM
JoshStrobl added a subscriber: JoshStrobl.

That's not how you remove extra unnecessary deps and "n/a" isn't a valid test plan. It is very much applicable.

This revision now requires changes to proceed.Feb 14 2020, 3:30 AM

Those packages are commented out right now because they don't exist in the repos yet. Currently I cannot test it because it crashes on start due to missing dependencies. Before this package is submitted those dependencies need to be packaged into the repos.

Those packages are commented out right now because they don't exist in the repos yet.

That's why we have solbuild local repositories: https://getsol.us/articles/packaging/local-repository/en/

By the way PyYAML is in the repository

algent added a subscriber: algent.Feb 14 2020, 9:52 AM

Two of the rundeps are already in repository:
python-xdg should be pyxdg
python-yaml should be pyyaml

jwinnie added a comment.EditedFeb 14 2020, 5:08 PM

@algent Is there any particular reason for this naming scheme? It seems rather inconsistent.

This kind of discussion is better to be done in our irc channel #Solus-Dev.

About pyxdg this is how its developer named it. The same with pyyaml.
You can see in repology.org how other distros have named these packages: pyyaml and pyxdg.

Also GtkStressTesting is named gst from its developer. Other distros followed also same naming, just gst.
I think it is better for solus too, to use name 'gst' instead of gtkstresstesting.

jwinnie updated this revision to Diff 19765.Feb 15 2020, 4:57 AM

Fixed issues mentioned by @algent

jwinnie updated this revision to Diff 19766.Feb 15 2020, 5:01 AM

Update pspec

JoshStrobl requested changes to this revision.Feb 15 2020, 11:35 AM

Changes didn't address my comments. Have further review items as well.

package.yml
7
pspec_x86_64.xml
23

This is going to conflict with any usage of the oh-my-zsh git plugin. Their meson.build for the gst binary should be patched to have binary be outputted as something like gtk-stress-testing.

Their service and desktop files will also likely need to be patched for the changed binary name: https://gitlab.com/leinardi/gst/-/tree/release/data

This revision now requires changes to proceed.Feb 15 2020, 11:35 AM

@JoshStrobl So should the packagename and everything be changed too, or just the binary?

jwinnie updated this revision to Diff 19812.Feb 17 2020, 8:58 PM

Fix license

YakoYakoYokuYoku added inline comments.
package.yml
2

gst is an alias for gstreamer, name should be gtk-stress-testing

JoshStrobl requested changes to this revision.Feb 18 2020, 2:15 PM

Name, binary, data (desktop files, service files, etc.). The site-packages could probably stay the same.

This revision now requires changes to proceed.Feb 18 2020, 2:15 PM

Also @YakoYakoYokuYoku, please leave the reviewing the Core Team and Global Maintainers. Thanks.

Should the name be GtkStressTesting or gtk-stress-testing?

Don't use capital letters in package name please.

jwinnie updated this revision to Diff 20068.Mar 1 2020, 1:02 AM
jwinnie marked an inline comment as done.

Change package name

jwinnie updated this revision to Diff 20069.Mar 1 2020, 1:19 AM
jwinnie marked an inline comment as done.

Apply patch to change name

jwinnie updated this revision to Diff 20070.Mar 1 2020, 1:36 AM
jwinnie marked an inline comment as done.

Fix source URL

jwinnie updated this revision to Diff 20074.Mar 1 2020, 2:26 AM

Uncomment dependencies (all dependencies have been packaged and submitted for review)

jwinnie updated this revision to Diff 20075.Mar 1 2020, 2:35 AM

Incorporate changes from @algent

jwinnie updated this revision to Diff 20076.Mar 1 2020, 2:37 AM

Rename patch

jwinnie updated this revision to Diff 20077.Mar 1 2020, 2:51 AM

Rename patch in package.yml

For some reason GtkStressTesting is saying that it's 0.6.1 even though the package.yml clearly states 0.7.1

jwinnie added a comment.EditedMar 1 2020, 3:56 AM
[Info] Building gtk-stress-testing-0.7.1
[Build] Building native package
[Source] Extracting source
[Build] Running step: build
[Build] Enabling ccache
+ cd /home/build/YPKG/root/gtk-stress-testing/build/gst-0.6.1-4179e7af494ef457a30e3a7c5af5f0868afea992

What?

jwinnie updated this revision to Diff 20078.Mar 1 2020, 4:22 AM

Fix hash

jwinnie updated this revision to Diff 20082.Mar 1 2020, 7:48 PM

Drop dependency on appstream-glib

jwinnie updated this revision to Diff 20083.Mar 1 2020, 8:12 PM

Add dependency python-typing-extensions

jwinnie updated this revision to Diff 20085.Mar 1 2020, 8:14 PM

Wait... python-typing-extensions should be dependency of python-injector

jwinnie updated this revision to Diff 20087.Mar 1 2020, 9:52 PM

Change name from gtk-stress-testing to gtkstresstesting (closer to upstream)

jwinnie updated this revision to Diff 20088.Mar 1 2020, 10:07 PM

Update patch title

jwinnie edited the summary of this revision. (Show Details)Mar 1 2020, 10:13 PM
jwinnie edited the test plan for this revision. (Show Details)

Your entire stack is inverted (going in the wrong direction).

@JoshStrobl Should be fixed now

JoshStrobl requested changes to this revision.Thu, Mar 19, 5:05 PM

Otherwise LGTM. Sorry for the delay in review, I was very pre-occupied with GNOME Stack upgrade.

package.yml
26

Patch and configure should go in setup step.

This revision now requires changes to proceed.Thu, Mar 19, 5:05 PM