Paths

Table of Contentst

Differential D8233

Update fish to 3.1.0
ClosedPublic
Actions

Authored by chax on Feb 12 2020, 6:59 PM.

Tags

None

Referenced Files

	F11023496: D8233.diff
	Tue, Aug 8, 2:46 PM

	F10951308: D8233.id19755.diff
	Sun, Jul 16, 11:07 AM

	F10859260: D8233.diff
	Jun 16 2023, 12:17 AM

	F10850963: D8233.id19755.diff
	Jun 12 2023, 8:20 AM

	F10845548: D8233.id19734.diff
	Jun 11 2023, 12:52 AM

	F10843236: D8233.id19755.diff
	Jun 10 2023, 5:17 PM

	F10843178: D8233.id.diff
	Jun 10 2023, 5:07 PM

	F10843172: D8233.id19734.diff
	Jun 10 2023, 5:06 PM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R759:3a954ee1e38c: Update fish to 3.1.0

Summary

Update fish to 3.1.0
Complete list of improvements and new features can be found here
Depends on D8231 D8236

Test Plan

Installed new version and opened new terminal session in fish.
Opened fish help
Opened fish manpages
Tested few command completions
Checked that all user fish configuratiions and functions load without issues

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

chax created this revision.Feb 12 2020, 6:59 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 12 2020, 6:59 PM

chax requested review of this revision.Feb 12 2020, 6:59 PM

chax mentioned this in D8230: Update fish to 3.1.0.Feb 12 2020, 7:02 PM

Hmm, something is fishy (pun intended) about sudo command completion. I'm investigating the issue and doing further testing of this new release.

Did a reboot and now everything works. I guess it's because i have fish setup as my login shell.

silke added a subscriber: silke.Feb 12 2020, 8:37 PM

silke added inline comments.

pspec_x86_64.xml
670	This conflicts with `ripgrep` as that package also provides the fish completion. Perhaps just remove `$installdir/usr/share/fish/completions/rg.fish` in the install step?

chax added a subscriber: DataDrake.Feb 12 2020, 8:43 PM

chax added inline comments.

pspec_x86_64.xml
670	hmm, or remove it from ripgrep package, as i did for bat like @DataDrake suggested.

DataDrake added inline comments.Feb 12 2020, 8:57 PM

pspec_x86_64.xml
670	If it's anything like the completions provided by `bat`, the `fish`-provided ones will be more complete and "correct".

silke added inline comments.Feb 12 2020, 9:02 PM

pspec_x86_64.xml
670	They are pretty much identical. But I agree with removing it in the `ripgrep` package, or moving it to the correct directory: `/usr/share/fish/vendor_completions.d` (per the fish documentation)

chax edited the summary of this revision. (Show Details)Feb 12 2020, 9:05 PM

chax added a parent revision: D8236: Remove fish completions from ripgrep.

chax added inline comments.Feb 12 2020, 9:21 PM

pspec_x86_64.xml
670	I just removed them, see D8231 and D8236. And i agree with you @silke if one of our packages wants/needs to provide it's own completion, it should be installed in `/usr/share/fish/vendor_completions.d`

LGTM, thanks!

This revision is now accepted and ready to land.Feb 14 2020, 3:19 AM

Closed by commit R759:3a954ee1e38c: Update fish to 3.1.0 (authored by chax, committed by JoshStrobl). · Explain WhyFeb 14 2020, 3:21 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R759:3a954ee1e38c: Update fish to 3.1.0.

Revision Contents
Changeset List

Path

Size

1 line

9 lines

pspec_x86_64.xml

309 lines

Diff 19734

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...