Page MenuHomeSolus

Update fish to 3.1.0
ClosedPublic

Authored by chax on Feb 12 2020, 6:59 PM.

Details

Summary

Update fish to 3.1.0
Complete list of improvements and new features can be found here
Depends on D8231 D8236

Test Plan
  • Installed new version and opened new terminal session in fish.
  • Opened fish help
  • Opened fish manpages
  • Tested few command completions
  • Checked that all user fish configuratiions and functions load without issues

Diff Detail

Repository
R759 fish
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Feb 12 2020, 6:59 PM
chax requested review of this revision.Feb 12 2020, 6:59 PM
chax added a comment.Feb 12 2020, 7:23 PM

Hmm, something is fishy (pun intended) about sudo command completion. I'm investigating the issue and doing further testing of this new release.

chax added a comment.Feb 12 2020, 7:35 PM

Did a reboot and now everything works. I guess it's because i have fish setup as my login shell.

silke added a subscriber: silke.Feb 12 2020, 8:37 PM
silke added inline comments.
pspec_x86_64.xml
670

This conflicts with ripgrep as that package also provides the fish completion.

Perhaps just remove $installdir/usr/share/fish/completions/rg.fish in the install step?

chax added a subscriber: DataDrake.Feb 12 2020, 8:43 PM
chax added inline comments.
pspec_x86_64.xml
670

hmm, or remove it from ripgrep package, as i did for bat like @DataDrake suggested.

DataDrake added inline comments.Feb 12 2020, 8:57 PM
pspec_x86_64.xml
670

If it's anything like the completions provided by bat, the fish-provided ones will be more complete and "correct".

silke added inline comments.Feb 12 2020, 9:02 PM
pspec_x86_64.xml
670

They are pretty much identical. But I agree with removing it in the ripgrep package, or moving it to the correct directory: /usr/share/fish/vendor_completions.d (per the fish documentation)

chax edited the summary of this revision. (Show Details)Feb 12 2020, 9:05 PM
chax added inline comments.Feb 12 2020, 9:21 PM
pspec_x86_64.xml
670

I just removed them, see D8231 and D8236.
And i agree with you @silke if one of our packages wants/needs to provide it's own completion, it should be installed in /usr/share/fish/vendor_completions.d

JoshStrobl accepted this revision.Feb 14 2020, 3:19 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Feb 14 2020, 3:19 AM
This revision was automatically updated to reflect the committed changes.