Page MenuHomeSolus

Rebuild onionshare for Python 3.7
ClosedPublic

Authored by Jacalz on Mon, Feb 10, 6:39 PM.

Details

Summary

This makes sure that onionshare works with the Python 3.7 upgrade.

Test Plan
  • Use the gui to share a file with myself.

Diff Detail

Repository
R4470 onionshare
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Mon, Feb 10, 6:39 PM
Jacalz requested review of this revision.Mon, Feb 10, 6:39 PM

It would be preferable to get this landed before the sync on Friday.

I suffer from a weird bug when trying to build this package, only reason i didn't push it.

[HISTORY] Could not load history file
File '/home/build/work/history.xml' has invalid XML
ERRO[15:47:01] Failed to build package                       error="exit status 1"

The only thing I can think of is the é character in your name which causes it, but you don't seem to suffer from the problem so idk *shrug*

Yeah I have the same issue here. Copying the files in to another folder, building and then copying back is the solution. The build server has rarely complained about this in the past.
This is the only package that suffers this issue so I highly doubt that my surname is the problem.

DataDrake accepted this revision.Thu, Feb 13, 7:38 AM
DataDrake added a subscriber: DataDrake.

I know how to fix this now, so LGTM.

This revision is now accepted and ready to land.Thu, Feb 13, 7:38 AM
This revision was automatically updated to reflect the committed changes.