Page MenuHomeSolus

Initial release of antimicroX
ClosedPublic

Authored by manokara on Feb 9 2020, 12:34 AM.

Details

Summary

Closes T8638

Test Plan

Built the package, but noticed I couldn't install the normal and -devel packages together because they had a cyclic dependency. Hmm. Turns out it was because the GUI depends on libantimicro, which is by default grabbed by the -devel subpackage, but -devel depends on the toplevel package, so a cycle happens. That was an easy fix with the libsplit: no directive in package.yml.

After installing, I opened the app and tested with a couple old profiles I had from the old antimicro and some new ones, everything seems to work fine.

Diff Detail

Repository
R4934 antimicrox
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manokara created this revision.Feb 9 2020, 12:34 AM
manokara requested review of this revision.Feb 9 2020, 12:34 AM
manokara updated this revision to Diff 19669.Feb 9 2020, 12:39 AM

Change the packager name in pspec

JoshStrobl requested changes to this revision.Feb 19 2020, 8:55 AM
JoshStrobl added a subscriber: JoshStrobl.

Please make sure you also include the following contents as a MAINTAINERS.md file:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- Mark Nokalt
  - IRC: manokara
  - Email: marknokalt@live.com
package.yml
8
12

explicit build deps (e.g. extra-cmake-modules) should be listed after pkgconfigs

14

gettext-devel is part of system.devel, not needed.

16

Not needed, this is a dep of qt5-base-devel which is a dep of qt5-tools-devel, which you have listed via the pkgconfig.

19

Not needed, check libxtst-devel deps.

20

Not needed, check libxtst-devel deps.

This revision now requires changes to proceed.Feb 19 2020, 8:55 AM
manokara updated this revision to Diff 19856.Feb 19 2020, 12:40 PM

Add MAINTAINERS.md and fix package.yml.

JoshStrobl requested changes to this revision.Thu, Mar 19, 5:07 PM

Otherwise LGTM!

package.yml
11

description should use the standard way we generate it during our generate script (available via Packaging Practices doc), e.g. description: |

This revision now requires changes to proceed.Thu, Mar 19, 5:07 PM
manokara updated this revision to Diff 20368.Fri, Mar 20, 5:31 AM

Correctly format package description

Oh, yauto is pretty handy, it even detects build systems! Totally skipped that section in Packaging Practices since I reused the old antimicro's package.yml...

JoshStrobl accepted this revision.Thu, Mar 26, 2:00 PM

LGTM, thanks!

This revision is now accepted and ready to land.Thu, Mar 26, 2:00 PM
This revision was automatically updated to reflect the committed changes.